From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=58841 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P5viA-0003ag-I7
	for qemu-devel@nongnu.org; Wed, 13 Oct 2010 03:25:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1P5vi9-0000MU-Ib
	for qemu-devel@nongnu.org; Wed, 13 Oct 2010 03:25:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:5229)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1P5vi9-0000MN-Bc
	for qemu-devel@nongnu.org; Wed, 13 Oct 2010 03:25:17 -0400
Message-ID: <4CB55ED8.6050705@redhat.com>
Date: Wed, 13 Oct 2010 09:25:12 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 07/39] do not pass bogus $(SRC_PATH) include
	paths to cc during configure
References: <1286888457-5033-1-git-send-email-pbonzini@redhat.com>
	<1286888457-5033-8-git-send-email-pbonzini@redhat.com>
	<AANLkTim4WDXCCi5WZTb50QdAyHXQkh9owd0eoDLcbhbp@mail.gmail.com>
In-Reply-To: <AANLkTim4WDXCCi5WZTb50QdAyHXQkh9owd0eoDLcbhbp@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

On 10/12/2010 09:09 PM, Blue Swirl wrote:
>>   QEMU_CFLAGS="-Wstrict-prototypes -Wredundant-decls $QEMU_CFLAGS"
>>   QEMU_CFLAGS="-D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE $QEMU_CFLAGS"
>>   QEMU_CFLAGS="-D_FORTIFY_SOURCE=2 $QEMU_CFLAGS"
>
> Aren't the above also CPP flags?

Yes, the difference is that the QEMU_CPPFLAGS are not used in the 
configure tests.  Instead, you need to use the above -D flags because 
they affect the system headers.  I'll rename QEMU_CPPFLAGS to QEMU_INCLUDES.

>> -LINK = $(call quiet-command,$(CC) $(QEMU_CFLAGS) $(CFLAGS) $(LDFLAGS) -o $@ $(1) $(LIBS),"  LINK  $(TARGET_DIR)$@")
>> +LINK = $(call quiet-command,$(CC) $(QEMU_CFLAGS) $(QEMU_CPPFLAGS) $(CFLAGS) $(LDFLAGS) -o $@ $(1) $(LIBS),"  LINK  $(TARGET_DIR)$@")
>
> I don't think the linker will use any CPP flags.

Yeah, though it doesn't use most CFLAGS either.  I'll remove the 
CPPFLAGS only, in both patches.

Paolo