From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=51688 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P6TnR-00020b-7i for qemu-devel@nongnu.org; Thu, 14 Oct 2010 15:49:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P6TnQ-0002v3-0C for qemu-devel@nongnu.org; Thu, 14 Oct 2010 15:49:01 -0400 Received: from mail-iw0-f173.google.com ([209.85.214.173]:38584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P6TnP-0002ur-S8 for qemu-devel@nongnu.org; Thu, 14 Oct 2010 15:48:59 -0400 Received: by iwn34 with SMTP id 34so7176306iwn.4 for ; Thu, 14 Oct 2010 12:48:59 -0700 (PDT) Message-ID: <4CB75EA4.9080004@codemonkey.ws> Date: Thu, 14 Oct 2010 14:48:52 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH] pc: e820 qemu_cfg tables need to be packed References: <20101014183249.23510.29196.stgit@s20.home> <4CB75D86.7040300@redhat.com> In-Reply-To: <4CB75D86.7040300@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes Sorensen Cc: Alex Williamson , qemu-devel@nongnu.org, kvm@vger.kernel.org On 10/14/2010 02:44 PM, Jes Sorensen wrote: > On 10/14/10 20:33, Alex Williamson wrote: > >> We can't let the compiler define the alignment for qemu_cfg data. >> >> Signed-off-by: Alex Williamson >> --- >> >> 0.13 stable candidate? >> > ACK I would say so. > fw_cfg interfaces are somewhat difficult to rationalize about for compatibility. 0.13.0 is tagged already so it's too late to pull it in there. If we say we don't care about compatibility at the fw_cfg level, then it doesn't matter if we pull it into stable-0.13. If we do care, then this is an ABI breaker. I don't know that the answer is obvious to me. Regards, Anthony Liguori > Jes > >