From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=34181 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P6nLV-0007J1-Us for qemu-devel@nongnu.org; Fri, 15 Oct 2010 12:41:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P6nLU-0005H1-V2 for qemu-devel@nongnu.org; Fri, 15 Oct 2010 12:41:29 -0400 Received: from mail-bw0-f45.google.com ([209.85.214.45]:42571) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P6nLU-0005Fp-QR for qemu-devel@nongnu.org; Fri, 15 Oct 2010 12:41:28 -0400 Received: by bwz6 with SMTP id 6so1560383bwz.4 for ; Fri, 15 Oct 2010 09:41:20 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4CB88421.2030107@redhat.com> Date: Fri, 15 Oct 2010 18:41:05 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1287151553-16894-1-git-send-email-Jes.Sorensen@redhat.com> In-Reply-To: <1287151553-16894-1-git-send-email-Jes.Sorensen@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 0/9] Re-factor osdep code + macro and brace fixes List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes.Sorensen@redhat.com Cc: qemu-devel@nongnu.org On 10/15/2010 04:05 PM, Jes.Sorensen@redhat.com wrote: > From: Jes Sorensen > > Hi, > > Here is another set of patches which tries to split up osdep.c further > into posix and win32 versions. It introduces os-{posix,win32}-lib.c > files which are used for functions that are OS specific core library > functionality, like gettimeofday(), and which is used by both QEMU and > support applications like qemu-img. Other functions are moved to > os-{posix,win32}.c. In addtion there are a couple of minor fixes for > bad macro names. > > In some cases braces were added to code when it was moved, to make it > compliant with the QEMU bracing rules. > > Cheers, > Jes > > > Jes Sorensen (9): > Move QEMU OS dependant library functions to OS specific files > Move osdep socket code to os-{posix,win32}-lib.c > qemu_pipe() is used only by POSIX code, so move to os-posix-lib.c > We only support eventfd under POSIX, move qemu_eventfd() to > os-posix.c > Move qemu_gettimeofday() to OS specific files > Do not redefine reserved key-words TRUE/FALSE > Separate qemu_pidfile() into OS specific versions > Consolidate oom_check() functions > Remove unncessary includes > > Makefile | 6 +- > Makefile.objs | 9 ++- > hw/bt-sdp.c | 21 +++-- > os-posix-lib.c | 111 +++++++++++++++++++++++ > os-posix.c | 53 +++++++++++ > os-win32-lib.c | 128 ++++++++++++++++++++++++++ > os-win32.c | 24 +++++ > osdep.c | 256 ---------------------------------------------------- > osdep.h | 15 --- > posix-aio-compat.c | 1 + > qemu-common.h | 1 + > qemu-img.c | 1 + > qemu-malloc.c | 14 +--- > qemu-os-posix.h | 3 + > qemu-os-win32.h | 9 ++ > qemu-tool.c | 1 + > 16 files changed, 357 insertions(+), 296 deletions(-) > create mode 100644 os-posix-lib.c > create mode 100644 os-win32-lib.c > ACK except for the nit in patch 5/9. Paolo