From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55153 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P77jJ-0006Kg-Hb
	for qemu-devel@nongnu.org; Sat, 16 Oct 2010 10:27:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1P77jI-000897-GD
	for qemu-devel@nongnu.org; Sat, 16 Oct 2010 10:27:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37653)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1P77jI-00088w-A1
	for qemu-devel@nongnu.org; Sat, 16 Oct 2010 10:27:24 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o9GERNs1009182
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Sat, 16 Oct 2010 10:27:23 -0400
Message-ID: <4CB9B649.7080809@redhat.com>
Date: Sat, 16 Oct 2010 16:27:21 +0200
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
References: <1287151553-16894-1-git-send-email-Jes.Sorensen@redhat.com>
	<1287151553-16894-6-git-send-email-Jes.Sorensen@redhat.com>
	<4CB883D6.8030100@redhat.com>
In-Reply-To: <4CB883D6.8030100@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 5/9] Move qemu_gettimeofday() to OS
	specific files
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On 10/15/10 18:39, Paolo Bonzini wrote:
> On 10/15/2010 04:05 PM, Jes.Sorensen@redhat.com wrote:
>> +typedef struct timeval qemu_timeval;
>> +#define qemu_gettimeofday(tp) gettimeofday(tp, NULL);
> 
> Argh, trailing semicolon.  Please remove it or use an inline function.

Good point, it is present in the existing code - it was a pure copy
paste. I'll fix it.

Cheers,
Jes