From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=58242 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P7AmO-0003AI-H4 for qemu-devel@nongnu.org; Sat, 16 Oct 2010 13:42:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P7AmM-0002RG-QU for qemu-devel@nongnu.org; Sat, 16 Oct 2010 13:42:48 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:58150) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P7AmM-0002Qq-G6 for qemu-devel@nongnu.org; Sat, 16 Oct 2010 13:42:46 -0400 Message-ID: <4CB9E413.5090400@web.de> Date: Sat, 16 Oct 2010 19:42:43 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4CB74350.80201@redhat.com> <4CB7AF6F.4010104@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: jan.kiszka@web.de Subject: [Qemu-devel] [PATCH] Silence compiler warning in json test case List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Paolo Bonzini , qemu-devel@nongnu.org Am 16.10.2010 18:28, Blue Swirl wrote: > On Sat, Oct 16, 2010 at 12:37 AM, Paolo Bonzini wrote: >> On 10/15/2010 07:41 PM, Blue Swirl wrote: >>> >>> Which functions are optimized away and which aren't? >> >> It's builtins only that are optimized away or otherwise inlined (printf, >> sprintf, etc.). Other calls stay, together with side effects and clock >> cycles. > > Then the warning makes sense (slightly) and should remain on main QEMU side. > From: Jan Kiszka This avoids error: zero-length gnu_printf format string Signed-off-by: Jan Kiszka --- check-qjson.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/check-qjson.c b/check-qjson.c index 0b60e45..64fcdcb 100644 --- a/check-qjson.c +++ b/check-qjson.c @@ -639,7 +639,9 @@ END_TEST START_TEST(empty_input) { - QObject *obj = qobject_from_json(""); + const char *empty = ""; + + QObject *obj = qobject_from_json(empty); fail_unless(obj == NULL); } END_TEST