From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 8/9] Consolidate oom_check() functions
Date: Mon, 18 Oct 2010 09:18:05 +0200 [thread overview]
Message-ID: <4CBBF4AD.3010601@redhat.com> (raw)
In-Reply-To: <AANLkTinYcOVwFW-dd3fbcXPkNHi_d5_-etLtYUxZcg-L@mail.gmail.com>
On 10/16/10 21:02, Blue Swirl wrote:
> On Sat, Oct 16, 2010 at 4:04 PM, <Jes.Sorensen@redhat.com> wrote:
>> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>>
>> This consolidates the duplicated oom_check() functions, as well as
>> splitting them into OS dependant versions to avoid the #ifdef
>> grossness that was present in the old osdep.c version.
>
> This would break user emulators:
> LINK i386-linux-user/qemu-i386
> qemu-malloc.o: In function `qemu_realloc':
> /src/qemu/qemu-malloc.c:60: undefined reference to `qemu_oom_check'
> qemu-malloc.o: In function `qemu_malloc':
> /src/qemu/qemu-malloc.c:49: undefined reference to `qemu_oom_check'
> qemu-malloc.o: In function `qemu_mallocz':
> /src/qemu/qemu-malloc.c:70: undefined reference to `qemu_oom_check'
> collect2: ld returned 1 exit status
I'll have a look.
Thanks,
Jes
next prev parent reply other threads:[~2010-10-18 7:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-16 16:04 [Qemu-devel] [PATCH v2 0/9] Re-factor osdep code + macro and brace fixes Jes.Sorensen
2010-10-16 16:04 ` [Qemu-devel] [PATCH 1/9] Move QEMU OS dependant library functions to OS specific files Jes.Sorensen
2010-10-16 16:04 ` [Qemu-devel] [PATCH 2/9] Move osdep socket code to oslib-{posix, win32}.c Jes.Sorensen
2010-10-16 16:04 ` [Qemu-devel] [PATCH 3/9] qemu_pipe() is used only by POSIX code, so move to oslib-posix.c Jes.Sorensen
2010-10-16 16:04 ` [Qemu-devel] [PATCH 4/9] We only support eventfd under POSIX, move qemu_eventfd() to os-posix.c Jes.Sorensen
2010-10-16 16:04 ` [Qemu-devel] [PATCH 5/9] Move qemu_gettimeofday() to OS specific files Jes.Sorensen
2010-10-16 19:32 ` [Qemu-devel] " Blue Swirl
2010-10-18 8:08 ` Jes Sorensen
2010-10-16 16:04 ` [Qemu-devel] [PATCH 6/9] Do not redefine reserved key-words TRUE/FALSE Jes.Sorensen
2010-10-16 16:04 ` [Qemu-devel] [PATCH 7/9] Separate qemu_pidfile() into OS specific versions Jes.Sorensen
2010-10-16 16:04 ` [Qemu-devel] [PATCH 8/9] Consolidate oom_check() functions Jes.Sorensen
2010-10-16 19:02 ` [Qemu-devel] " Blue Swirl
2010-10-18 7:18 ` Jes Sorensen [this message]
2010-10-16 16:04 ` [Qemu-devel] [PATCH 9/9] Remove unncessary includes Jes.Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CBBF4AD.3010601@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).