From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43970 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P7jzM-0004Vh-UX
	for qemu-devel@nongnu.org; Mon, 18 Oct 2010 03:18:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1P7jz2-0005wM-Ll
	for qemu-devel@nongnu.org; Mon, 18 Oct 2010 03:18:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:16317)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1P7jz2-0005ve-FM
	for qemu-devel@nongnu.org; Mon, 18 Oct 2010 03:18:12 -0400
Message-ID: <4CBBF4AD.3010601@redhat.com>
Date: Mon, 18 Oct 2010 09:18:05 +0200
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
References: <1287245083-26110-1-git-send-email-Jes.Sorensen@redhat.com>
	<1287245083-26110-9-git-send-email-Jes.Sorensen@redhat.com>
	<AANLkTinYcOVwFW-dd3fbcXPkNHi_d5_-etLtYUxZcg-L@mail.gmail.com>
In-Reply-To: <AANLkTinYcOVwFW-dd3fbcXPkNHi_d5_-etLtYUxZcg-L@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 8/9] Consolidate oom_check() functions
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org

On 10/16/10 21:02, Blue Swirl wrote:
> On Sat, Oct 16, 2010 at 4:04 PM,  <Jes.Sorensen@redhat.com> wrote:
>> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>>
>> This consolidates the duplicated oom_check() functions, as well as
>> splitting them into OS dependant versions to avoid the #ifdef
>> grossness that was present in the old osdep.c version.
> 
> This would break user emulators:
>   LINK  i386-linux-user/qemu-i386
> qemu-malloc.o: In function `qemu_realloc':
> /src/qemu/qemu-malloc.c:60: undefined reference to `qemu_oom_check'
> qemu-malloc.o: In function `qemu_malloc':
> /src/qemu/qemu-malloc.c:49: undefined reference to `qemu_oom_check'
> qemu-malloc.o: In function `qemu_mallocz':
> /src/qemu/qemu-malloc.c:70: undefined reference to `qemu_oom_check'
> collect2: ld returned 1 exit status

I'll have a look.

Thanks,
Jes