From: Kevin Wolf <kwolf@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH v2][qemu-iotests] Improve test for qemu-img convert with backing file
Date: Mon, 18 Oct 2010 09:34:16 +0200 [thread overview]
Message-ID: <4CBBF878.7010105@redhat.com> (raw)
In-Reply-To: <20101015211109.GA30107@lst.de>
Am 15.10.2010 23:11, schrieb Christoph Hellwig:
> On Fri, Oct 15, 2010 at 06:05:39PM +0200, Kevin Wolf wrote:
>> Additionally to testing the qemu-img convert -B option, also test
>> -o backing_file.
>>
>> Also, the old test acidentlly used a pattern of zeros for most of the writes,
>> so that the allocation test didn't really work out. This is fixed by using an
>> explicit pattern.
>>
>> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>> ---
>> v2:
>> - Include changes to 019.out to contain the expected output for the new script.
>> The test still fails on git master, but that's a real qemu-img bug.
>
> I'd rather wait adding more testing until it actually works. The
> alternative would be to move the test for the new option into a separate
> test case.
It's going to get forgotten this way, but it's your decision. Certainly
at some point I'll notice that I have a local patch that isn't applied
yet and I can resend it then.
Kevin
prev parent reply other threads:[~2010-10-18 7:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 16:05 [Qemu-devel] [PATCH v2][qemu-iotests] Improve test for qemu-img convert with backing file Kevin Wolf
2010-10-15 21:11 ` [Qemu-devel] " Christoph Hellwig
2010-10-18 7:34 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CBBF878.7010105@redhat.com \
--to=kwolf@redhat.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).