From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34731 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P7kEe-0002Mx-QQ
	for qemu-devel@nongnu.org; Mon, 18 Oct 2010 03:34:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1P7kE5-0000bH-3I
	for qemu-devel@nongnu.org; Mon, 18 Oct 2010 03:33:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:16403)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1P7kE4-0000b9-T7
	for qemu-devel@nongnu.org; Mon, 18 Oct 2010 03:33:45 -0400
Message-ID: <4CBBF878.7010105@redhat.com>
Date: Mon, 18 Oct 2010 09:34:16 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1287158739-14635-1-git-send-email-kwolf@redhat.com>
	<20101015211109.GA30107@lst.de>
In-Reply-To: <20101015211109.GA30107@lst.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v2][qemu-iotests] Improve test for qemu-img
 convert with backing file
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org

Am 15.10.2010 23:11, schrieb Christoph Hellwig:
> On Fri, Oct 15, 2010 at 06:05:39PM +0200, Kevin Wolf wrote:
>> Additionally to testing the qemu-img convert -B option, also test
>> -o backing_file.
>>
>> Also, the old test acidentlly used a pattern of zeros for most of the writes,
>> so that the allocation test didn't really work out. This is fixed by using an
>> explicit pattern.
>>
>> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>> ---
>> v2:
>> - Include changes to 019.out to contain the expected output for the new script.
>>   The test still fails on git master, but that's a real qemu-img bug.
> 
> I'd rather wait adding more testing until it actually works.  The
> alternative would be to move the test for the new option into a separate
> test case.

It's going to get forgotten this way, but it's your decision. Certainly
at some point I'll notice that I have a local patch that isn't applied
yet and I can resend it then.

Kevin