From: Gerd Hoffmann <kraxel@redhat.com>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Markus Armbruster <armbru@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI device id in PCI ROM
Date: Mon, 18 Oct 2010 15:30:55 +0200 [thread overview]
Message-ID: <4CBC4C0F.3060204@redhat.com> (raw)
In-Reply-To: <4CBC48A0.3030701@mail.berlios.de>
Hi,
>> When following this argumentation the vendor id sanity check shouldn't
>> be there in the first place ;)
>
> The sanity check is simply there because I had no test case
> which patches the vendor id. How could I test with vga bios?
No trivial way as the vgabios needs to be patched to handle that.
The vgabios searches for its hardware, right now the IDs are
compile-time constants (same constants are compiled into the pci
header). Needs to be changed to lookup the ID at runtime in the pci header.
cheers,
Gerd
next prev parent reply other threads:[~2010-10-18 13:31 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 12:41 [Qemu-devel] Where's gpxe-eepro100-80862449.rom ? Markus Armbruster
2010-10-12 16:18 ` [Qemu-devel] " Stefan Weil
2010-10-13 7:13 ` Markus Armbruster
2010-10-15 20:51 ` [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI device id in PCI ROM Stefan Weil
2010-10-15 21:05 ` Anthony Liguori
2010-10-18 10:09 ` Gerd Hoffmann
2010-10-18 18:39 ` Anthony Liguori
2010-10-21 10:09 ` [SeaBIOS] " Avi Kivity
2010-10-21 13:14 ` Anthony Liguori
2010-10-21 15:34 ` Avi Kivity
2010-10-18 10:04 ` Gerd Hoffmann
2010-10-18 11:16 ` Stefan Weil
2010-10-18 11:54 ` Gerd Hoffmann
2010-10-18 13:16 ` Stefan Weil
2010-10-18 13:30 ` Gerd Hoffmann [this message]
2010-10-18 15:50 ` Gerd Hoffmann
2010-10-18 17:54 ` Stefan Weil
2010-10-18 17:55 ` [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and " Stefan Weil
2010-10-18 17:58 ` [Qemu-devel] " Michael S. Tsirkin
2010-10-18 18:42 ` Anthony Liguori
2010-10-18 19:03 ` Michael S. Tsirkin
2010-10-18 19:36 ` Stefan Weil
2010-10-18 19:59 ` Anthony Liguori
2010-10-19 6:40 ` Gerd Hoffmann
2010-10-18 19:56 ` Anthony Liguori
2010-10-18 18:44 ` [Qemu-devel] " Anthony Liguori
2010-10-18 18:53 ` Anthony Liguori
2010-10-18 19:11 ` Stefan Weil
2010-10-19 8:37 ` Michael S. Tsirkin
2010-10-19 21:15 ` Stefan Weil
2010-10-19 21:22 ` Anthony Liguori
2010-10-19 21:25 ` Michael S. Tsirkin
2010-10-19 21:08 ` Stefan Weil
2010-10-20 7:19 ` [Qemu-devel] " Gerd Hoffmann
2010-10-20 20:30 ` Stefan Weil
2010-11-22 6:29 ` Michael S. Tsirkin
2010-10-15 20:51 ` [Qemu-devel] [PATCH 2/2] eepro100: Use a single rom file for all i825xx devices Stefan Weil
2010-11-22 6:29 ` [Qemu-devel] " Michael S. Tsirkin
2010-10-15 21:03 ` [Qemu-devel] Re: Where's gpxe-eepro100-80862449.rom ? Stefan Weil
2010-10-25 12:11 ` Markus Armbruster
2010-10-25 16:23 ` Stefan Weil
2010-10-25 16:54 ` Michael S. Tsirkin
2010-11-15 17:06 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CBC4C0F.3060204@redhat.com \
--to=kraxel@redhat.com \
--cc=armbru@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).