From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40093 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P7pnr-0004BV-PB
	for qemu-devel@nongnu.org; Mon, 18 Oct 2010 09:31:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1P7pnq-0003er-8g
	for qemu-devel@nongnu.org; Mon, 18 Oct 2010 09:31:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39941)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1P7pnq-0003el-2B
	for qemu-devel@nongnu.org; Mon, 18 Oct 2010 09:31:02 -0400
Message-ID: <4CBC4C0F.3060204@redhat.com>
Date: Mon, 18 Oct 2010 15:30:55 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI device
	id in	PCI ROM
References: <m3bp6y5zvu.fsf@blackfin.pond.sub.org>	<1287175867-7757-1-git-send-email-weil@mail.berlios.de>	<4CBC1BA8.7030604@redhat.com>
	<4CBC2C7A.4000803@mail.berlios.de> <4CBC3572.6000908@redhat.com>
	<4CBC48A0.3030701@mail.berlios.de>
In-Reply-To: <4CBC48A0.3030701@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Markus Armbruster <armbru@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, "Michael S. Tsirkin" <mst@redhat.com>

   Hi,

>> When following this argumentation the vendor id sanity check shouldn't
>> be there in the first place ;)
>
> The sanity check is simply there because I had no test case
> which patches the vendor id. How could I test with vga bios?

No trivial way as the vgabios needs to be patched to handle that.

The vgabios searches for its hardware, right now the IDs are 
compile-time constants (same constants are compiled into the pci 
header).  Needs to be changed to lookup the ID at runtime in the pci header.

cheers,
   Gerd