From: Anthony Liguori <anthony@codemonkey.ws>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Gerd Hoffmann <kraxel@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM
Date: Mon, 18 Oct 2010 14:59:09 -0500 [thread overview]
Message-ID: <4CBCA70D.9030900@codemonkey.ws> (raw)
In-Reply-To: <4CBCA1AB.5010701@mail.berlios.de>
On 10/18/2010 02:36 PM, Stefan Weil wrote:
> Maybe a more perfect solution would only patch the preconfigured
> rom files but not user configured files, but I don't think we
> need this degree of perfection.
Generally speaking, patching third-party code is not something that we
should get in the habit of doing unless we're very very sure that it's
okay and we have as many checks in place as possible to avoid bad things
from happening.
There are so many bad things that can happen. If attempted to support
attestation in QEMU and prepopulated a virtual TPM with checksums from
the BIOS and ROMs, when the virtual BIOS attempts to measure itself if
we've patched the ROM underneath of it, then the measurements will fail.
In the very least, if we go this route, it has to be an optional feature.
Regards,
Anthony Liguori
> Regards,
> Stefan
>
next prev parent reply other threads:[~2010-10-18 19:59 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 12:41 [Qemu-devel] Where's gpxe-eepro100-80862449.rom ? Markus Armbruster
2010-10-12 16:18 ` [Qemu-devel] " Stefan Weil
2010-10-13 7:13 ` Markus Armbruster
2010-10-15 20:51 ` [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI device id in PCI ROM Stefan Weil
2010-10-15 21:05 ` Anthony Liguori
2010-10-18 10:09 ` Gerd Hoffmann
2010-10-18 18:39 ` Anthony Liguori
2010-10-21 10:09 ` [SeaBIOS] " Avi Kivity
2010-10-21 13:14 ` Anthony Liguori
2010-10-21 15:34 ` Avi Kivity
2010-10-18 10:04 ` Gerd Hoffmann
2010-10-18 11:16 ` Stefan Weil
2010-10-18 11:54 ` Gerd Hoffmann
2010-10-18 13:16 ` Stefan Weil
2010-10-18 13:30 ` Gerd Hoffmann
2010-10-18 15:50 ` Gerd Hoffmann
2010-10-18 17:54 ` Stefan Weil
2010-10-18 17:55 ` [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and " Stefan Weil
2010-10-18 17:58 ` [Qemu-devel] " Michael S. Tsirkin
2010-10-18 18:42 ` Anthony Liguori
2010-10-18 19:03 ` Michael S. Tsirkin
2010-10-18 19:36 ` Stefan Weil
2010-10-18 19:59 ` Anthony Liguori [this message]
2010-10-19 6:40 ` Gerd Hoffmann
2010-10-18 19:56 ` Anthony Liguori
2010-10-18 18:44 ` [Qemu-devel] " Anthony Liguori
2010-10-18 18:53 ` Anthony Liguori
2010-10-18 19:11 ` Stefan Weil
2010-10-19 8:37 ` Michael S. Tsirkin
2010-10-19 21:15 ` Stefan Weil
2010-10-19 21:22 ` Anthony Liguori
2010-10-19 21:25 ` Michael S. Tsirkin
2010-10-19 21:08 ` Stefan Weil
2010-10-20 7:19 ` [Qemu-devel] " Gerd Hoffmann
2010-10-20 20:30 ` Stefan Weil
2010-11-22 6:29 ` Michael S. Tsirkin
2010-10-15 20:51 ` [Qemu-devel] [PATCH 2/2] eepro100: Use a single rom file for all i825xx devices Stefan Weil
2010-11-22 6:29 ` [Qemu-devel] " Michael S. Tsirkin
2010-10-15 21:03 ` [Qemu-devel] Re: Where's gpxe-eepro100-80862449.rom ? Stefan Weil
2010-10-25 12:11 ` Markus Armbruster
2010-10-25 16:23 ` Stefan Weil
2010-10-25 16:54 ` Michael S. Tsirkin
2010-11-15 17:06 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CBCA70D.9030900@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).