From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=57628 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P84av-0006j6-MY
	for qemu-devel@nongnu.org; Tue, 19 Oct 2010 01:18:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <prerna@linux.vnet.ibm.com>) id 1P84aq-0005Qi-Vf
	for qemu-devel@nongnu.org; Tue, 19 Oct 2010 01:18:41 -0400
Received: from e23smtp07.au.ibm.com ([202.81.31.140]:38520)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prerna@linux.vnet.ibm.com>) id 1P84aq-0005Qb-Es
	for qemu-devel@nongnu.org; Tue, 19 Oct 2010 01:18:36 -0400
Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [202.81.31.245])
	by e23smtp07.au.ibm.com (8.14.4/8.13.1) with ESMTP id o9J5IW91004714
	for <qemu-devel@nongnu.org>; Tue, 19 Oct 2010 16:18:32 +1100
Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97])
	by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	o9J5IVDO1036362
	for <qemu-devel@nongnu.org>; Tue, 19 Oct 2010 16:18:31 +1100
Received: from d23av03.au.ibm.com (loopback [127.0.0.1])
	by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	o9J5IVhf011528
	for <qemu-devel@nongnu.org>; Tue, 19 Oct 2010 16:18:31 +1100
Message-ID: <4CBD29BC.4020403@linux.vnet.ibm.com>
Date: Tue, 19 Oct 2010 10:46:44 +0530
From: Prerna Saxena <prerna@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <20101018113655.09b6a48d@zephyr> <20101018122156.3410da09@doriath>
In-Reply-To: <20101018122156.3410da09@doriath>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [Tracing][RFC v3 PATCH 0/2] QMP Query interfaces
	for tracing
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Mahesh <mahesh@linux.vnet.ibm.com>, Anthony Liguori <aliguori@us.ibm.com>, Ananth Narayan <ananth@linux.vnet.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

On 10/18/2010 07:51 PM, Luiz Capitulino wrote:
> On Mon, 18 Oct 2010 11:36:55 +0530
> Prerna Saxena<prerna@linux.vnet.ibm.com>  wrote:
>
>> This patch set introduces two QMP interfaces for tracing :
>>
>> * query-trace        : to list current contents of trace-buffer
>> * query-trace-events : to list all available trace-events with their state.
>
> This is in my to-review queue, but it's going to take a few days, because
> I have to take a deeper look at the tracing feature to be able to review it.
>

Thanks for looking..I'd look forward to your comments :-)

> Two initial questions:
>
>   o This is labeled as an RFC, but you're versioning it. Should this be
>     considered for inclusion?

I'm sending out a new version with some enhancements shortly -- for 
inclusion.

>
>   o Is this really useful w/o being able to set new traces?
>

I'm working on that as well. The query commands are the earliest 
interfaces to be implemented. I will be adding interfaces to toggle the 
state of trace-events, set a new trace-file, etc.

>>
>> Changelog :
>> -----------
>> Changes v2 ->  v3 :
>> - Change declarations of st_print_trace_to_qlist() and
>> st_print_trace_events_to_qlist() to return QList*
>>
>> Changes v1 ->  v2 :
>> - Add 'timestamp' field for query-trace output.
>> - Misc cleanups.
>>
>

Thanks,
-- 
Prerna Saxena

Linux Technology Centre,
IBM Systems and Technology Lab,
Bangalore, India