From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=60473 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P8CDu-0007an-JV
	for qemu-devel@nongnu.org; Tue, 19 Oct 2010 09:27:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1P8CDt-0003Q8-N5
	for qemu-devel@nongnu.org; Tue, 19 Oct 2010 09:27:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:64666)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1P8CDt-0003Q1-GJ
	for qemu-devel@nongnu.org; Tue, 19 Oct 2010 09:27:25 -0400
Message-ID: <4CBD9CB3.5080609@redhat.com>
Date: Tue, 19 Oct 2010 15:27:15 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: KVM call agenda for Oct 19
References: <m3ocar5wxn.fsf@trasno.mitica>
	<20101019021117.GI25455@sequoia.sous-sol.org>
	<4CBD93B8.9070002@redhat.com> <4CBD9B87.9010008@codemonkey.ws>
In-Reply-To: <4CBD9B87.9010008@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: chrisw@redhat.com, kvm@vger.kernel.org, Juan Quintela <quintela@redhat.com>, dlaor@redhat.com, qemu-devel@nongnu.org, Chris Wright <chrisw@sous-sol.org>, Ayal Baron <abaron@redhat.com>, "Venkateswararao Jujjuri (JV)" <jvrao@linux.vnet.ibm.com>

  On 10/19/2010 03:22 PM, Anthony Liguori wrote:
>
> I had assumed that this would involve:
>
> qemu -hda windows.img
>
> (qemu) snapshot ide0-disk0 snap0.img
>
> 1) create snap0.img internally by doing the equivalent of `qemu-img 
> create -f qcow2 -b windows.img snap0.img'
> 2) bdrv_flush('ide0-disk0')
> 3) bdrv_open(snap0.img)
> 4) bdrv_close(windows.img)
> 5) rename('windows.img', 'windows.img.tmp')
> 6) rename('snap0.img', 'windows.img')
> 7) rename('windows.img.tmp', 'snap0.img')
>

Looks reasonable.

Would be interesting to look at this as a use case for the threading 
work.  We should eventually be able to create a snapshot without 
stalling vcpus (stalling I/O of course allowed).

-- 
error compiling committee.c: too many arguments to function