From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=34869 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P8CLt-0003Nr-NS for qemu-devel@nongnu.org; Tue, 19 Oct 2010 09:35:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P8CLK-0005xL-BP for qemu-devel@nongnu.org; Tue, 19 Oct 2010 09:35:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25038) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P8CLK-0005wy-4M for qemu-devel@nongnu.org; Tue, 19 Oct 2010 09:35:06 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o9JDZ5PP021506 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 19 Oct 2010 09:35:05 -0400 Message-ID: <4CBD9E85.50908@redhat.com> Date: Tue, 19 Oct 2010 15:35:01 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 3/3] monitor: add usb_attach and usb_detach References: <1287484411-13611-1-git-send-email-alevy@redhat.com> <1287484411-13611-4-git-send-email-alevy@redhat.com> In-Reply-To: <1287484411-13611-4-git-send-email-alevy@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: qemu-devel@nongnu.org Hi, > + .help = "attach USB device 'bus.addr'", > +@item usb_attach @var{devname} /me sees a mismatch here. There is still the use case question. Also note that this might have unwanted side effects when drivers automagically attach/detach devices like usb-host. Having this purely for debugging/troubleshooting purposes would be fine with me, but the documentation should clearly say so. cheers, Gerd