From: Jan Kiszka <jan.kiszka@siemens.com>
To: Alexander Graf <agraf@suse.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH][RESEND] char: Flush read buffer in mux_chr_can_read
Date: Tue, 19 Oct 2010 17:26:38 +0200 [thread overview]
Message-ID: <4CBDB8AE.5050904@siemens.com> (raw)
In-Reply-To: <ABBA21B4-7FC3-4766-9A45-A360740A54BD@suse.de>
Am 19.10.2010 17:22, Alexander Graf wrote:
>
> Am 19.10.2010 um 17:04 schrieb Jan Kiszka <jan.kiszka@siemens.com>:
>
>> Move the buffer flush from mux_chr_read to mux_chr_can_read. While the
>> latter is called periodically, the former will only be invoked when new
>> characters arrive at the back-end. This caused problems to front-end
>> drivers whenever they were unable to read data immediately, e.g.
>> virtio-console attached to stdio.
>
> This should help ny s390 virtio console issue, right? :) I'll try it out asap, worst case that might take until the weekend.
I think you already tried and still found some scenarios broken (we
still need to understand them IIRC). However, this one fixes at least
those virtio-console scenarios I tested (with x86 guests).
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2010-10-19 15:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 15:04 [Qemu-devel] [PATCH][RESEND] char: Flush read buffer in mux_chr_can_read Jan Kiszka
2010-10-19 15:22 ` [Qemu-devel] " Alexander Graf
2010-10-19 15:26 ` Jan Kiszka [this message]
2010-11-17 10:18 ` Jan Kiszka
2010-11-17 11:55 ` Alexander Graf
2010-11-17 11:58 ` Jan Kiszka
2010-11-17 12:00 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CBDB8AE.5050904@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=agraf@suse.de \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).