From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=50641 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P8Epg-0000AV-7Z for qemu-devel@nongnu.org; Tue, 19 Oct 2010 12:14:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P8Epf-0003QE-8X for qemu-devel@nongnu.org; Tue, 19 Oct 2010 12:14:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59590) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P8Epf-0003Pw-1d for qemu-devel@nongnu.org; Tue, 19 Oct 2010 12:14:35 -0400 Message-ID: <4CBDC40F.9090707@redhat.com> Date: Tue, 19 Oct 2010 18:15:11 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1287417233-23688-1-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1287417233-23688-1-git-send-email-stefanha@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH][block] qcow2: Support exact L1 table growth List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org Am 18.10.2010 17:53, schrieb Stefan Hajnoczi: > The L1 table grow operation includes a size calculation that bumps up > the new L1 table size in order to anticipate the size needs of vmstate > data. This helps reduce the number of times that the L1 table has to be > grown when vmstate data is appended. > > This size overhead is not necessary during image creation, > bdrv_truncate(), or snapshot goto operations. In fact, existing > qemu-iotests that exercise table growth are no longer able to trigger it > because image creation preallocates an L1 table that is too large after > changes to qcow_create2(). > > This patch keeps the size calculation but also adds exact growth for > callers that do not want to inflate the L1 table size unnecessarily. > > Signed-off-by: Stefan Hajnoczi Thanks, applied to the block branch. Kevin