From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=49410 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P8Jde-0007AD-Ms
	for qemu-devel@nongnu.org; Tue, 19 Oct 2010 17:22:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1P8Jdd-00047l-JC
	for qemu-devel@nongnu.org; Tue, 19 Oct 2010 17:22:30 -0400
Received: from mail-qy0-f173.google.com ([209.85.216.173]:49173)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1P8Jdd-00047f-Ag
	for qemu-devel@nongnu.org; Tue, 19 Oct 2010 17:22:29 -0400
Received: by qyl33 with SMTP id 33so803455qyl.4
	for <qemu-devel@nongnu.org>; Tue, 19 Oct 2010 14:22:28 -0700 (PDT)
Message-ID: <4CBE0C0F.8030507@codemonkey.ws>
Date: Tue, 19 Oct 2010 16:22:23 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor
	id and device id in PCI ROM
References: <4CBC6CDB.109@redhat.com>
	<1287424511-22021-1-git-send-email-weil@mail.berlios.de>
	<4CBC957D.3040007@codemonkey.ws> <4CBC97BE.7070902@codemonkey.ws>
	<4CBC9BFB.9090504@mail.berlios.de>
	<20101019083740.GA4465@redhat.com>
	<4CBE0A7A.5030500@mail.berlios.de>
In-Reply-To: <4CBE0A7A.5030500@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>, Markus Armbruster <armbru@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>

On 10/19/2010 04:15 PM, Stefan Weil wrote:
> Am 19.10.2010 10:37, schrieb Michael S. Tsirkin:
>> On Mon, Oct 18, 2010 at 09:11:55PM +0200, Stefan Weil wrote:
>>> QEMU must only make sure that patching of the supported roms
>>> with supported devices work.
>>
>> I think that's what Anthony was saying too - make this depend
>> on a qdev property and set it only in eepro100 for now.
>>
>
> My new patch v3 implements something similar and does not need
> a new qdev property:

I prefer to have an explicit property in case a user actually wants to 
use this functionality.   That said, if Michael's happy with the 
approach, I'm okay with it too.

Regards,

Anthony Liguori

> Don't patch because the rom file was defined by the user:
>
> qemu -L pc-bios -boot n -netdev user,id=internet \
>     -device i82801,netdev=internet,romfile=gpxe-eepro100-80861209.rom
>
> Patch because we work with the built-in default rom file:
>
> qemu -L pc-bios -boot n -netdev user,id=internet \
>     -device i82801,netdev=internet
>
> This is a safe solution which respects user's rom data
> without adding much more complexity.
>
> Regards,
> Stefan
>