From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=53127 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P8YY3-0001XZ-8w
	for qemu-devel@nongnu.org; Wed, 20 Oct 2010 09:17:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1P8YY1-0002zc-Rs
	for qemu-devel@nongnu.org; Wed, 20 Oct 2010 09:17:42 -0400
Received: from mail-qy0-f180.google.com ([209.85.216.180]:62318)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1P8YY1-0002zS-Ll
	for qemu-devel@nongnu.org; Wed, 20 Oct 2010 09:17:41 -0400
Received: by qyk1 with SMTP id 1so2978310qyk.4
	for <qemu-devel@nongnu.org>; Wed, 20 Oct 2010 06:17:41 -0700 (PDT)
Message-ID: <4CBEEBF0.50408@codemonkey.ws>
Date: Wed, 20 Oct 2010 08:17:36 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/3] Add helper functions for virtio-9p to
	use threadlets
References: <20101019173946.16514.62027.stgit@localhost6.localdomain6>	<20101019174350.16514.66426.stgit@localhost6.localdomain6>
	<AANLkTik_eyQuM9rZ2D_-kiPthxcTr-dMBckHP_AR3nj8@mail.gmail.com>
In-Reply-To: <AANLkTik_eyQuM9rZ2D_-kiPthxcTr-dMBckHP_AR3nj8@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Arun R Bharadwaj <arun@linux.vnet.ibm.com>, qemu-devel@nongnu.org

On 10/20/2010 06:19 AM, Stefan Hajnoczi wrote:
> On Tue, Oct 19, 2010 at 6:43 PM, Arun R Bharadwaj
> <arun@linux.vnet.ibm.com>  wrote:
>    
>> From: Gautham R Shenoy<ego@in.ibm.com>
>>
>> Add helper functions to enable virtio-9p make use of the threadlets
>> infrastructure for offloading blocking tasks such as making posix calls on
>> to the helper threads and handle the post_posix_operations() from the
>> context of the iothread. This frees the vcpu thread to process any other guest
>> operations while the processing of v9fs_io is in progress.
>>
>> Signed-off-by: Gautham R Shenoy<ego@in.ibm.com>
>> Signed-off-by: Sripathi Kodi<sripathik@in.ibm.com>
>> Signed-off-by: Arun R Bharadwaj<arun@linux.vnet.ibm.com>
>> ---
>>   hw/virtio-9p.c     |  165 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>>   posix-aio-compat.c |   33 +++-------
>>   qemu-threadlets.c  |   21 +++++++
>>   qemu-threadlets.h  |    1
>>   vl.c               |    3 +
>>   5 files changed, 200 insertions(+), 23 deletions(-)
>>      
> I wish --enable-io-thread was the default and only model.  The signals
> and pipes are ugly and should be hidden behind a QEMU eventfd
> abstraction, which would also reduce the code duplication between
> posix-aio-compat.c and virtio-9p.  I'm not asking you to do this but I
> hope we'll get there eventually.
>
> Does anyone know why non-io-thread still exists and is used by default?
>    

There are still issues with --enable-io-thread and TCG.

Regards,

Anthony Liguori