From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37082 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P8h4r-0004Le-JB
	for qemu-devel@nongnu.org; Wed, 20 Oct 2010 18:24:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1P8h4n-0003Du-Ml
	for qemu-devel@nongnu.org; Wed, 20 Oct 2010 18:24:09 -0400
Received: from mail-qy0-f180.google.com ([209.85.216.180]:38046)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1P8h4n-0003Dn-J8
	for qemu-devel@nongnu.org; Wed, 20 Oct 2010 18:24:05 -0400
Received: by qyk1 with SMTP id 1so3163540qyk.4
	for <qemu-devel@nongnu.org>; Wed, 20 Oct 2010 15:24:05 -0700 (PDT)
Message-ID: <4CBF6C04.3020502@codemonkey.ws>
Date: Wed, 20 Oct 2010 17:24:04 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/2] Use defines instead of numbers for pci
	hotplug sts bit
References: <1287308725-30811-1-git-send-email-gleb@redhat.com>
In-Reply-To: <1287308725-30811-1-git-send-email-gleb@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gleb Natapov <gleb@redhat.com>
Cc: qemu-devel@nongnu.org

On 10/17/2010 04:45 AM, Gleb Natapov wrote:
> Signed-off-by: Gleb Natapov<gleb@redhat.com>
>    

Applied both.  Thanks.

Regards,

Anthony Liguori

> ---
>   hw/acpi_piix4.c |    6 ++++--
>   1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
> index c8733e5..bec42b4 100644
> --- a/hw/acpi_piix4.c
> +++ b/hw/acpi_piix4.c
> @@ -38,6 +38,8 @@
>   #define PCI_BASE 0xae00
>   #define PCI_EJ_BASE 0xae08
>
> +#define PIIX4_PCI_HOTPLUG_STATUS 2
> +
>   struct gpe_regs {
>       uint16_t sts; /* status */
>       uint16_t en;  /* enabled */
> @@ -596,13 +598,13 @@ static void piix4_acpi_system_hot_add_init(PCIBus *bus, PIIX4PMState *s)
>
>   static void enable_device(PIIX4PMState *s, int slot)
>   {
> -    s->gpe.sts |= 2;
> +    s->gpe.sts |= PIIX4_PCI_HOTPLUG_STATUS;
>       s->pci0_status.up |= (1<<  slot);
>   }
>
>   static void disable_device(PIIX4PMState *s, int slot)
>   {
> -    s->gpe.sts |= 2;
> +    s->gpe.sts |= PIIX4_PCI_HOTPLUG_STATUS;
>       s->pci0_status.down |= (1<<  slot);
>   }
>
>