From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56452 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P8rwg-0002aa-Ay
	for qemu-devel@nongnu.org; Thu, 21 Oct 2010 06:00:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1P8rwf-0002IO-6O
	for qemu-devel@nongnu.org; Thu, 21 Oct 2010 06:00:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:3266)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1P8rwe-0002Ho-Tf
	for qemu-devel@nongnu.org; Thu, 21 Oct 2010 06:00:25 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o9LA0I4n013250
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 21 Oct 2010 06:00:19 -0400
Message-ID: <4CC00F2C.2090302@redhat.com>
Date: Thu, 21 Oct 2010 12:00:12 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/3] monitor: add usb_attach and usb_detach
References: <1287484411-13611-1-git-send-email-alevy@redhat.com>	<1287484411-13611-4-git-send-email-alevy@redhat.com>	<4CBD9E85.50908@redhat.com>
	<20101020142420.675fb9d3@doriath>
In-Reply-To: <20101020142420.675fb9d3@doriath>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Alon Levy <alevy@redhat.com>, qemu-devel@nongnu.org

On 10/20/10 18:24, Luiz Capitulino wrote:
> On Tue, 19 Oct 2010 15:35:01 +0200
> Gerd Hoffmann<kraxel@redhat.com>  wrote:
>
>>     Hi,
>>
>>> +        .help       = "attach USB device 'bus.addr'",
>>
>>> +@item usb_attach @var{devname}
>>
>> /me sees a mismatch here.
>>
>> There is still the use case question.  Also note that this might have
>> unwanted side effects when drivers automagically attach/detach devices
>> like usb-host.
>
> Alon, did you check this? I hope it doesn't blowup.
>
>> Having this purely for debugging/troubleshooting purposes would be fine
>> with me, but the documentation should clearly say so.
>
> Is this useful in production or only in the development of new devices?

I'd say more a development tool.

> If
> it's the letter, then I would even prefer enabling them only when DEBUG
> is enabled.

Makes sense indeed.

cheers,
   Gerd