From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48599 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P8s3S-0007TF-Fp
	for qemu-devel@nongnu.org; Thu, 21 Oct 2010 06:07:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1P8s3R-0003rv-8N
	for qemu-devel@nongnu.org; Thu, 21 Oct 2010 06:07:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:14975)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1P8s3R-0003rp-1t
	for qemu-devel@nongnu.org; Thu, 21 Oct 2010 06:07:25 -0400
Message-ID: <4CC010D5.7070103@redhat.com>
Date: Thu, 21 Oct 2010 12:07:17 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <20101020093441.GP10207@redhat.com>
	<20101021020020.GA21095@morn.localdomain>
In-Reply-To: <20101021020020.GA21095@morn.localdomain>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [SeaBIOS] [PATCH] mark irq9 active high in DSDT
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: KVM list <kvm@vger.kernel.org>, seabios@seabios.org, qemu-devel <qemu-devel@nongnu.org>, Gleb Natapov <gleb@redhat.com>, "Justin M. Forbes" <jforbes@redhat.com>

  On 10/21/2010 04:00 AM, Kevin O'Connor wrote:
> On Wed, Oct 20, 2010 at 11:34:41AM +0200, Gleb Natapov wrote:
> >  In PIIX4 SCI (irq9) is active high. Seabios marks it so in interrupt
> >  override table, but some OSes (FreeBSD) require the same information to
> >  be present in DSDT too. Make it so.
> >
> >  Signed-off-by: Gleb Natapov<gleb@redhat.com>
>
> Thanks.

How do we manage the stable series wrt this issue?

qemu-kvm-0.12.5 has a regression within the stable series that this 
patch fixes.  qemu 0.12.5 does not, but only because it does not emulate 
polarity in the I/O APIC correctly.

There are several paths we could take:

- do nothing, bug is fixed in mainline
- release a seabios 0.x.1 for qemu 0.13.1 with this patch
- same, plus seabios 0.y.1 for qemu 0.12.6 with this patch
- skip qemu (which is not truly affected), patch qemu-kvm's copy of 
seabios for both 0.12.z and 0.13.z

The third option is the most "correct" from a release engineering point 
of view, but involves more work for everyone.  The fourth is quick pain 
relief but is a little forky.

-- 
error compiling committee.c: too many arguments to function