From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=53957 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P8uxN-0007KA-JU
	for qemu-devel@nongnu.org; Thu, 21 Oct 2010 09:13:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1P8uxM-00026I-97
	for qemu-devel@nongnu.org; Thu, 21 Oct 2010 09:13:21 -0400
Received: from mail-qw0-f45.google.com ([209.85.216.45]:50483)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1P8uxM-000268-48
	for qemu-devel@nongnu.org; Thu, 21 Oct 2010 09:13:20 -0400
Received: by qwh5 with SMTP id 5so3688687qwh.4
	for <qemu-devel@nongnu.org>; Thu, 21 Oct 2010 06:13:19 -0700 (PDT)
Message-ID: <4CC03C6F.4020304@codemonkey.ws>
Date: Thu, 21 Oct 2010 08:13:19 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)
References: <1287642991-21114-1-git-send-email-alevy@redhat.com>
	<4CC03A2D.9030105@redhat.com>
In-Reply-To: <4CC03A2D.9030105@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Alon Levy <alevy@redhat.com>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

On 10/21/2010 08:03 AM, Gerd Hoffmann wrote:
> On 10/21/10 08:36, Alon Levy wrote:
>> v2->v3 changes:
>>   * add configure parameter
>>   * fix docs
>>
>> v2 message:
>> This patchset uses id like device_del for attaching/detaching usb
>> devices. The first two patches ready the way:
>>   1. makes qdev_find_recursive non static and in qdev.h
>>   2. adds a usb_device_by_id which goes over the usb buses calling
>>    qdev_find_recursive
>>   3. adds the commands that use usb_device_by_id
>>
>> Alon Levy (3):
>>    qdev: make qdev_find_recursive public
>>    usb: add public usb_device_by_id
>>    monitor: add usb_attach and usb_detach (v2)
>>
>
> Acked-by: Gerd Hoffmann <kraxel@redhat.com>

Okay, I am still confused about the use-case for this and I don't see 
any further explanation in the commit messages.  I've seen "debugging" 
but can you be a bit more specific about which cases it's needed for?

This is just adding a HMP command.  Is that the right approach or was 
that an unintentional consequence of rebasing post-HMP/QMP split?

Regards,

Anthony Liguori

>
> cheers,
>   Gerd
>
>