From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56850 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P9Ewo-0001kn-BE
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 06:34:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1P9Ewn-0006PS-2H
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 06:34:06 -0400
Received: from moutng.kundenserver.de ([212.227.126.187]:61092)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1P9Ewm-0006Oz-Ma
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 06:34:05 -0400
Message-ID: <4CC16896.3090609@mail.berlios.de>
Date: Fri, 22 Oct 2010 12:33:58 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
References: <1286996067-25440-1-git-send-email-weil@mail.berlios.de>
	<1286996067-25440-2-git-send-email-weil@mail.berlios.de>
In-Reply-To: <1286996067-25440-2-git-send-email-weil@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 2/2] Replace remaining gcc format
 attributes by macro GCC_FMT_ATTR (format checking)
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Am 13.10.2010 20:54, schrieb Stefan Weil:
> Replace the remaining format attribute printf by macro
> GCC_FMT_ATTR which uses gnu_printf (if supported).
>
> v2
> * Removal of dyngen specific code is now done in a separate patch.
> * Handle attribute in new ui/spice-display.c, too.
>
> Cc: Blue Swirl<blauwirbel@gmail.com>
> Signed-off-by: Stefan Weil<weil@mail.berlios.de>
> ---
>   cpu-all.h          |    2 +-
>   ui/spice-display.c |    3 +--
>   2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/cpu-all.h b/cpu-all.h
> index 67a3266..11edddc 100644
> --- a/cpu-all.h
> +++ b/cpu-all.h
> @@ -773,7 +773,7 @@ void cpu_dump_statistics (CPUState *env, FILE *f,
>                             int flags);
>
>   void QEMU_NORETURN cpu_abort(CPUState *env, const char *fmt, ...)
> -    __attribute__ ((__format__ (__printf__, 2, 3)));
> +    GCC_FMT_ATTR(2, 3);
>   extern CPUState *first_cpu;
>   extern CPUState *cpu_single_env;
>
> diff --git a/ui/spice-display.c b/ui/spice-display.c
> index 6702dfd..7b4f5c1 100644
> --- a/ui/spice-display.c
> +++ b/ui/spice-display.c
> @@ -29,8 +29,7 @@
>
>   static int debug = 0;
>
> -static void __attribute__((format(printf,2,3)))
> -dprint(int level, const char *fmt, ...)
> +static void GCC_FMT_ATTR(2, 3) dprint(int level, const char *fmt, ...)
>   {
>       va_list args;
>
>    


Can these two patches be applied to qemu master, or is there still 
something missing?
They are needed for additional format checks.

Regards,
Stefan