From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43297 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P9HuE-0002LR-Pg
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 09:43:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1P9Hu8-0003F5-Nc
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 09:43:38 -0400
Received: from mail-yx0-f173.google.com ([209.85.213.173]:54510)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1P9Hu8-0003Eo-IO
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 09:43:32 -0400
Received: by yxd5 with SMTP id 5so681504yxd.4
	for <qemu-devel@nongnu.org>; Fri, 22 Oct 2010 06:43:31 -0700 (PDT)
Message-ID: <4CC1950B.5020805@codemonkey.ws>
Date: Fri, 22 Oct 2010 08:43:39 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)
References: <1287642991-21114-1-git-send-email-alevy@redhat.com>	<4CC03A2D.9030105@redhat.com>	<4CC03C6F.4020304@codemonkey.ws>	<20101021132723.GE22958@playa.tlv.redhat.com>	<20101022104822.5f608f13@doriath>	<4CC189A6.30807@codemonkey.ws>
	<20101022111744.69c4be17@doriath>
In-Reply-To: <20101022111744.69c4be17@doriath>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Alon Levy <alevy@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org

On 10/22/2010 08:17 AM, Luiz Capitulino wrote:
> You and Gerd asked about the purpose of this command, turns out that it's
> only useful for developing new USB devices for QEMU, so I thought it would
> be better to restrict it, so that people don't start using this the
> wrong way or worse, we can't drop/break it because some tool is now using it.
>    

Need HMP commands have no support associated with them.  Given QMP, 
there's no reason to script HMP commands.

But a long standing policy in QEMU has been to avoid conditional code 
because it results in dead code.  I think this policy has actually 
worked well for us historically.

Regards,

Anthony Liguori

> Anyway, maybe a good doc will do, this was just a small suggestion.
>
>    
>>      
>>> Objections, Anthony?
>>>
>>>        
>> Not with better docs.
>>
>> Regards,
>>
>> Anthony Liguori
>>
>>      
>>>>> This is just adding a HMP command.  Is that the right approach or
>>>>> was that an unintentional consequence of rebasing post-HMP/QMP
>>>>> split?
>>>>>
>>>>>            
>>> I don't think this should be available under QMP, it's more a debugging
>>> command for USB developers.
>>>
>>>
>>>        
>>>>> Regards,
>>>>>
>>>>> Anthony Liguori
>>>>>
>>>>>
>>>>>            
>>>>>> cheers,
>>>>>>    Gerd
>>>>>>
>>>>>>
>>>>>>
>>>>>>              
>>>>>
>>>>>            
>>>>
>>>>          
>>>
>>>        
>>      
>