From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37948 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P9Iyb-0005kR-3n
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 10:52:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1P9IyZ-0007Zk-Ff
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 10:52:12 -0400
Received: from mail-gw0-f45.google.com ([74.125.83.45]:50284)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1P9IyZ-0007Zd-Bv
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 10:52:11 -0400
Received: by gwj16 with SMTP id 16so1208831gwj.4
	for <qemu-devel@nongnu.org>; Fri, 22 Oct 2010 07:52:10 -0700 (PDT)
Message-ID: <4CC1A523.5040701@codemonkey.ws>
Date: Fri, 22 Oct 2010 09:52:19 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH v6 07/12] pcie/hotplug: introduce pushing
	attention button command
References: <cover.1287562197.git.yamahata@valinux.co.jp>	<2f5cb93039ab90a7b267334dd5e2e94b7a550b9f.1287562197.git.yamahata@valinux.co.jp>	<20101020100011.GE10783@redhat.com>	<m3lj5qxxws.fsf@blackfin.pond.sub.org>
	<20101022143849.GC23469@redhat.com>
In-Reply-To: <20101022143849.GC23469@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: skandasa@cisco.com, lmr@redhat.com, etmartin@cisco.com, wexu2@cisco.com, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Isaku Yamahata <yamahata@valinux.co.jp>, kraxel@redhat.com

On 10/22/2010 09:38 AM, Michael S. Tsirkin wrote:
> On Fri, Oct 22, 2010 at 01:35:47PM +0200, Markus Armbruster wrote:
>    
>> "Michael S. Tsirkin"<mst@redhat.com>  writes:
>>
>>      
>>> On Wed, Oct 20, 2010 at 05:18:56PM +0900, Isaku Yamahata wrote:
>>>        
>>>> glue pcie_push_attention_button command.
>>>>
>>>> Signed-off-by: Isaku Yamahata<yamahata@valinux.co.jp>
>>>>          
>>> So as a high level command, I think we need to
>>> think about how to tie this into pci_add/pci_del.
>>> Right?
>>>        
>> [...]
>>
>> Do we have consensus how our set of commands for hot plug should look
>> like?  We talked about it, but did we reach consensus?  If yes, did we
>> write it down somewhere?
>>      
> I think for simple things yes:
> - command to send hotplug notification to the guest
> - command to immediately add/remove the device
> - event to notify about guest ack
>    

Is it a guest ack?  I thought it was actually an eject that can be 
initiated without the notification being sent to the guest.

If so, polling doesn't really make much sense.

Regards,

Anthony Liguori

> - way to poll status: did guest ack last command?
>
> Existing ones will keep function:
> - send notification and when acked remove device
> - add device and send notification
> These are useful for human monitor but maybe not
> for management.
>
>
>