From: Kevin Wolf <kwolf@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Anthony Liguori <aliguori@linux.vnet.ibm.com>,
Ryan Harper <ryanh@us.ibm.com>,
Stefan Hajnoczi <stefan.hajnoczi@uk.ibm.com>,
hch@lst.de
Subject: Re: [Qemu-devel] [PATCH 0/2] v3 Decouple block device removal from device removal
Date: Fri, 22 Oct 2010 18:11:22 +0200 [thread overview]
Message-ID: <4CC1B7AA.9090506@redhat.com> (raw)
In-Reply-To: <20101022134850.083085dd@doriath>
Am 22.10.2010 17:48, schrieb Luiz Capitulino:
> On Thu, 21 Oct 2010 21:55:51 -0500
> Ryan Harper <ryanh@us.ibm.com> wrote:
>
>> This patch series decouples the detachment of a block device from the removal
>> of the backing pci-device. Removal of a hotplugged pci device requires the
>> guest to respond before qemu tears down the block device. In some cases, the
>> guest may not respond leaving the guest with continued access to the block
>> device.
>>
>> The new monitor command, drive_unplug, will revoke a guests access to the
>> block device independently of the removal of the pci device.
>>
>> The first patch adds a new drive find method, the second patch implements the
>> monitor command and block layer changes.
>
> Reviewed the monitor part, I think we're waiting for Kevin's and/or
> Markus's ACK to get this merged?
Yes, I'm waiting for Markus' comments before applying this.
Maybe we shouldn't add this to QMP yet, drive_add doesn't exist there
either because we want to do it right with blockdev_add/del. On the
other hand Markus should know much better than me what the right thing
would look like - if he says that this interface will work with whatever
we're going to get with blockdev_*, I'm fine with merging it.
Kevin
next prev parent reply other threads:[~2010-10-22 16:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 2:55 [Qemu-devel] [PATCH 0/2] v3 Decouple block device removal from device removal Ryan Harper
2010-10-22 2:55 ` [Qemu-devel] [PATCH 1/2] v2 Add drive_get_by_id Ryan Harper
2010-10-22 15:41 ` Luiz Capitulino
2010-10-22 2:55 ` [Qemu-devel] [PATCH 2/2] v3 Fix Block Hotplug race with drive_unplug() Ryan Harper
2010-10-22 15:46 ` Luiz Capitulino
2010-10-22 15:48 ` [Qemu-devel] [PATCH 0/2] v3 Decouple block device removal from device removal Luiz Capitulino
2010-10-22 16:11 ` Kevin Wolf [this message]
2010-10-22 16:58 ` Ryan Harper
2010-10-25 18:31 ` Ryan Harper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC1B7AA.9090506@redhat.com \
--to=kwolf@redhat.com \
--cc=aliguori@linux.vnet.ibm.com \
--cc=armbru@redhat.com \
--cc=hch@lst.de \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ryanh@us.ibm.com \
--cc=stefan.hajnoczi@uk.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).