From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34994 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PAF5g-0005iv-EW
	for qemu-devel@nongnu.org; Mon, 25 Oct 2010 00:55:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <prerna@linux.vnet.ibm.com>) id 1PAF5d-0002St-Oq
	for qemu-devel@nongnu.org; Mon, 25 Oct 2010 00:55:24 -0400
Received: from e23smtp07.au.ibm.com ([202.81.31.140]:39243)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prerna@linux.vnet.ibm.com>) id 1PAF5d-0002SM-8G
	for qemu-devel@nongnu.org; Mon, 25 Oct 2010 00:55:21 -0400
Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [202.81.31.245])
	by e23smtp07.au.ibm.com (8.14.4/8.13.1) with ESMTP id o9P4tEUW010051
	for <qemu-devel@nongnu.org>; Mon, 25 Oct 2010 15:55:14 +1100
Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97])
	by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	o9P4tDiQ684078
	for <qemu-devel@nongnu.org>; Mon, 25 Oct 2010 15:55:14 +1100
Received: from d23av03.au.ibm.com (loopback [127.0.0.1])
	by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	o9P4tDqR006599
	for <qemu-devel@nongnu.org>; Mon, 25 Oct 2010 15:55:13 +1100
Message-ID: <4CC50DAF.9060401@linux.vnet.ibm.com>
Date: Mon, 25 Oct 2010 10:25:11 +0530
From: Prerna Saxena <prerna@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <20101021144929.7911128a@zephyr> <20101021151018.3d12b5f1@zephyr>
	<20101022152757.GB14171@stefan-thinkpad.transitives.com>
In-Reply-To: <20101022152757.GB14171@stefan-thinkpad.transitives.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [RFC][PATCH 4/5] trace-event
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Mahesh <mahesh@linux.vnet.ibm.com>, Ananth Narayan <ananth@linux.vnet.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Luiz Capitulino <lcapitulino@redhat.com>

On 10/22/2010 08:57 PM, Stefan Hajnoczi wrote:
> On Thu, Oct 21, 2010 at 03:10:18PM +0530, Prerna Saxena wrote:
>> trace-event : QMP interface to change state of a trace-event.
>> (Analogous to hmp command : trace-event )
>>
>> Signed-off-by: Prerna Saxena<prerna@linux.vnet.ibm.com>
>> ---
>>   qmp-commands.hx |   32 ++++++++++++++++++++++++++++++++
>>   1 files changed, 32 insertions(+), 0 deletions(-)
>>
>> diff --git a/qmp-commands.hx b/qmp-commands.hx
>> index 7e95f4e..f2008e8 100644
>> --- a/qmp-commands.hx
>> +++ b/qmp-commands.hx
>> @@ -761,6 +761,38 @@ Example:
>>
>>   Note: This command must be issued before issuing any other command.
>>
>> +EQMP
>> +
>> +    {
>> +        .name       = "trace-event",
>> +        .args_type  = "name:s,option:b",
>> +        .params     = "name on|off",
>> +        .help       = "changes state of a specific trace event",
>> +        .user_print = monitor_user_noop,
>> +        .mhandler.cmd_new = do_change_trace_event_state_qmp,
>> +    },
>> +
>> +SQMP
>> +trace-event
>> +-----------
>> +
>> +Change state of a trace-event.
>
> The name is a little odd because it has no verb.  How about
> set-trace-event or enable-trace-event?
>

Sure, makes sense.
I'll incorporate this when I send out the next set of patches.

Thanks,
-- 
Prerna Saxena

Linux Technology Centre,
IBM Systems and Technology Lab,
Bangalore, India