From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49917 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PAMbP-00064r-5o for qemu-devel@nongnu.org; Mon, 25 Oct 2010 08:56:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PAMbN-0006pt-O4 for qemu-devel@nongnu.org; Mon, 25 Oct 2010 08:56:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27171) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PAMbN-0006ph-F5 for qemu-devel@nongnu.org; Mon, 25 Oct 2010 08:56:37 -0400 Message-ID: <4CC57E80.10001@redhat.com> Date: Mon, 25 Oct 2010 14:56:32 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1287934469-16624-1-git-send-email-avi@redhat.com> <1287934469-16624-2-git-send-email-avi@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 1/2] Type-safe ioport callbacks List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On 10/25/2010 02:54 PM, Juan Quintela wrote: > Avi Kivity wrote: > > > +static void ioport_writeb_thunk(void *opaque, uint32_t addr, uint32_t data) > > +{ > > + IOPort *ioport = opaque; > > + > > + return ioport->ops->writeb(ioport, addr, data); > > +} > > + > > +static void ioport_writew_thunk(void *opaque, uint32_t addr, uint32_t data) > > +{ > > + IOPort *ioport = opaque; > > + > > + return ioport->ops->writew(ioport, addr, data); > > +} > > + > > +static void ioport_writel_thunk(void *opaque, uint32_t addr, uint32_t data) > > +{ > > + IOPort *ioport = opaque; > > + > > + return ioport->ops->writel(ioport, addr, data); > > +} > > "return" is not needed on this three functions. > Fixed. -- error compiling committee.c: too many arguments to function