From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35097 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PANNF-0007s8-80 for qemu-devel@nongnu.org; Mon, 25 Oct 2010 09:46:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PANN9-00077N-4g for qemu-devel@nongnu.org; Mon, 25 Oct 2010 09:46:00 -0400 Received: from mail-qw0-f45.google.com ([209.85.216.45]:35222) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PANN9-00077B-2U for qemu-devel@nongnu.org; Mon, 25 Oct 2010 09:45:59 -0400 Received: by qwf7 with SMTP id 7so1518976qwf.4 for ; Mon, 25 Oct 2010 06:45:58 -0700 (PDT) Message-ID: <4CC58A14.2030502@codemonkey.ws> Date: Mon, 25 Oct 2010 08:45:56 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/2] Type-safe ioport callbacks References: <1287934469-16624-1-git-send-email-avi@redhat.com> In-Reply-To: <1287934469-16624-1-git-send-email-avi@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On 10/24/2010 10:34 AM, Avi Kivity wrote: > A recent qemu -> qemu-kvm merge broke cpu hotplug without the compiler > complaining because of the type-unsafeness of the ioport callbacks. This > patchset adds a type-safe variant of ioport callbacks and coverts a sample > ioport. Converting the other 300-odd registrations is left as an excercise > to the community. > > Avi Kivity (2): > Type-safe ioport callbacks > piix4 acpi: convert io BAR to type-safe ioport callbacks > Makes sense. Acked-by: Anthony Liguori Regards, Anthony Liguori > hw/acpi_piix4.c | 30 +++++++++++++++---------- > ioport.c | 64 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > ioport.h | 16 +++++++++++++ > 3 files changed, 98 insertions(+), 12 deletions(-) > >