From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=41082 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PAV7d-0001xx-J2
	for qemu-devel@nongnu.org; Mon, 25 Oct 2010 18:02:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PAV7c-0007xj-Hn
	for qemu-devel@nongnu.org; Mon, 25 Oct 2010 18:02:29 -0400
Received: from mail-qy0-f180.google.com ([209.85.216.180]:53125)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PAV7c-0007xf-FX
	for qemu-devel@nongnu.org; Mon, 25 Oct 2010 18:02:28 -0400
Received: by qyk8 with SMTP id 8so2234126qyk.4
	for <qemu-devel@nongnu.org>; Mon, 25 Oct 2010 15:02:28 -0700 (PDT)
Message-ID: <4CC5FE75.4040502@codemonkey.ws>
Date: Mon, 25 Oct 2010 17:02:29 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC][PATCH 01/10] virtagent: add common rpc
	transport defs
References: <1287773165-24855-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1287773165-24855-2-git-send-email-mdroth@linux.vnet.ibm.com>
	<4CC5F919.4000102@codemonkey.ws>
	<alpine.LNX.2.00.1010260154001.2152@linmac>
In-Reply-To: <alpine.LNX.2.00.1010260154001.2152@linmac>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: abeekhof@redhat.com, ryanh@us.ibm.com, agl@linux.vnet.ibm.com, Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org

On 10/25/2010 04:54 PM, malc wrote:
> On Mon, 25 Oct 2010, Anthony Liguori wrote:
>
>    
>> On 10/22/2010 01:45 PM, Michael Roth wrote:
>>      
>>> Common code for sending/recieving RPCs via http over virtproxy channel.
>>> Eventually these will all be switched to asynchronous handlers to avoid
>>> deadlocks between qemu and the guest. For now we can usually get away with
>>> just doing asynchronous reads for http/RPC responses if we don't send
>>> large RPC requests to the guest (since these will likely get buffered
>>> rather than block or cause spinning on writes).
>>>        
> [..snip..]
>
>    
>> expressions need spaces.  IOW, i=0; i<len; ++i should be i = 0; i<  len; i++.
>>
>> Avoid C++ isms like ++i.
>>      
> Why?
>    

Because it creates arbitrary inconsistency.

Regards,

Anthony Liguori

> [..snip..]
>
>