From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=51565 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PAjWs-0005o0-Hc
	for qemu-devel@nongnu.org; Tue, 26 Oct 2010 09:25:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PAjWf-00085Z-LE
	for qemu-devel@nongnu.org; Tue, 26 Oct 2010 09:25:30 -0400
Received: from mail-yw0-f45.google.com ([209.85.213.45]:64938)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PAjWf-00085G-ID
	for qemu-devel@nongnu.org; Tue, 26 Oct 2010 09:25:17 -0400
Received: by ywh1 with SMTP id 1so3100664ywh.4
	for <qemu-devel@nongnu.org>; Tue, 26 Oct 2010 06:25:17 -0700 (PDT)
Message-ID: <4CC6D6BA.8000007@codemonkey.ws>
Date: Tue, 26 Oct 2010 08:25:14 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/5] Keep track of ISA ports ISA device is
	using in qdev.
References: <1288090091-25874-1-git-send-email-gleb@redhat.com>
	<1288090091-25874-2-git-send-email-gleb@redhat.com>
In-Reply-To: <1288090091-25874-2-git-send-email-gleb@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gleb Natapov <gleb@redhat.com>
Cc: qemu-devel@nongnu.org

On 10/26/2010 05:48 AM, Gleb Natapov wrote:
> Store all io ports used by device in ISADevice structure.
>
> Signed-off-by: Gleb Natapov<gleb@redhat.com>
> ---
>   hw/cs4231a.c     |    1 +
>   hw/fdc.c         |    3 +++
>   hw/gus.c         |    4 ++++
>   hw/ide/isa.c     |    2 ++
>   hw/isa-bus.c     |   25 +++++++++++++++++++++++++
>   hw/isa.h         |    4 ++++
>   hw/m48t59.c      |    1 +
>   hw/mc146818rtc.c |    1 +
>   hw/ne2000-isa.c  |    3 +++
>   hw/parallel.c    |    5 +++++
>   hw/pckbd.c       |    3 +++
>   hw/sb16.c        |    4 ++++
>   hw/serial.c      |    1 +
>   13 files changed, 57 insertions(+), 0 deletions(-)
>
> diff --git a/hw/cs4231a.c b/hw/cs4231a.c
> index 4d5ce5c..598f032 100644
> --- a/hw/cs4231a.c
> +++ b/hw/cs4231a.c
> @@ -645,6 +645,7 @@ static int cs4231a_initfn (ISADevice *dev)
>       isa_init_irq (dev,&s->pic, s->irq);
>
>       for (i = 0; i<  4; i++) {
> +        isa_init_ioport(dev, i);
>           register_ioport_write (s->port + i, 1, 1, cs_write, s);
>           register_ioport_read (s->port + i, 1, 1, cs_read, s);
>    

A better way to do this would be to introduce isa_register_ioport.

We can take Avi's series first since that probably makes this easier to 
implement.

Regards,

Anthony Liguori