From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Juan Quintela <quintela@redhat.com>, Avi Kivity <avi@redhat.com>,
kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] qcow2: Fix segfault when qcow2 preallocate fails
Date: Tue, 26 Oct 2010 15:48:03 +0200 [thread overview]
Message-ID: <4CC6DC13.5090509@redhat.com> (raw)
In-Reply-To: <1288099399-10010-1-git-send-email-stefanha@linux.vnet.ibm.com>
Am 26.10.2010 15:23, schrieb Stefan Hajnoczi:
> When an image is created with -o preallocate, ensure that we only call
> preallocate() if the image was indeed opened successfully. Also use
> bdrv_delete() instead of bdrv_close() to avoid leaking the
> BlockDriverState structure.
>
> This fixes the segfault reported at
> https://bugzilla.redhat.com/show_bug.cgi?id=646538.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Looks good for stable-0.13. In master we'll have the new qcow_create2
implementation as soon as Anthony pulls, so it doesn't apply there.
Kevin
next prev parent reply other threads:[~2010-10-26 13:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-25 19:51 [Qemu-devel] KVM call agenda for Oct 26 Juan Quintela
2010-10-25 19:53 ` [Qemu-devel] " Chris Wright
2010-10-26 8:20 ` Avi Kivity
2010-10-26 12:49 ` Anthony Liguori
2010-10-26 13:04 ` Avi Kivity
2010-10-26 13:22 ` Anthony Liguori
2010-10-26 13:24 ` Gleb Natapov
2010-10-26 13:23 ` [Qemu-devel] [PATCH] qcow2: Fix segfault when qcow2 preallocate fails Stefan Hajnoczi
2010-10-26 13:48 ` Kevin Wolf [this message]
2010-10-26 14:04 ` [Qemu-devel] " Stefan Hajnoczi
2010-10-26 13:09 ` [Qemu-devel] Re: KVM call agenda for Oct 26 Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC6DC13.5090509@redhat.com \
--to=kwolf@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).