From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=41206 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PAjsB-0005da-0K
	for qemu-devel@nongnu.org; Tue, 26 Oct 2010 09:47:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PAjs9-0005O4-P4
	for qemu-devel@nongnu.org; Tue, 26 Oct 2010 09:47:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:26725)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PAjs9-0005Nr-If
	for qemu-devel@nongnu.org; Tue, 26 Oct 2010 09:47:29 -0400
Message-ID: <4CC6DC13.5090509@redhat.com>
Date: Tue, 26 Oct 2010 15:48:03 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <4CC6D1EA.7050706@redhat.com>
	<1288099399-10010-1-git-send-email-stefanha@linux.vnet.ibm.com>
In-Reply-To: <1288099399-10010-1-git-send-email-stefanha@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] qcow2: Fix segfault when qcow2 preallocate
	fails
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Juan Quintela <quintela@redhat.com>, Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org

Am 26.10.2010 15:23, schrieb Stefan Hajnoczi:
> When an image is created with -o preallocate, ensure that we only call
> preallocate() if the image was indeed opened successfully.  Also use
> bdrv_delete() instead of bdrv_close() to avoid leaking the
> BlockDriverState structure.
> 
> This fixes the segfault reported at
> https://bugzilla.redhat.com/show_bug.cgi?id=646538.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

Looks good for stable-0.13. In master we'll have the new qcow_create2
implementation as soon as Anthony pulls, so it doesn't apply there.

Kevin