From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=38557 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PAzxM-0004ok-Fu
	for qemu-devel@nongnu.org; Wed, 27 Oct 2010 02:58:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <prerna@linux.vnet.ibm.com>) id 1PAzwW-0001vK-5c
	for qemu-devel@nongnu.org; Wed, 27 Oct 2010 02:57:05 -0400
Received: from e28smtp03.in.ibm.com ([122.248.162.3]:43910)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prerna@linux.vnet.ibm.com>) id 1PAzwV-0001tk-9J
	for qemu-devel@nongnu.org; Wed, 27 Oct 2010 02:57:04 -0400
Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62])
	by e28smtp03.in.ibm.com (8.14.4/8.13.1) with ESMTP id o9R6uqnE024901
	for <qemu-devel@nongnu.org>; Wed, 27 Oct 2010 12:26:52 +0530
Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63])
	by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	o9R6upjc3301542
	for <qemu-devel@nongnu.org>; Wed, 27 Oct 2010 12:26:51 +0530
Received: from d28av01.in.ibm.com (loopback [127.0.0.1])
	by d28av01.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	o9R6upWf029423
	for <qemu-devel@nongnu.org>; Wed, 27 Oct 2010 12:26:51 +0530
Message-ID: <4CC7CD32.3040906@linux.vnet.ibm.com>
Date: Wed, 27 Oct 2010 12:26:50 +0530
From: Prerna Saxena <prerna@linux.vnet.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2] Add a DTrace tracing backend targetted
	for SystemTAP compatability
References: <1287583790-9349-1-git-send-email-berrange@redhat.com>
In-Reply-To: <1287583790-9349-1-git-send-email-berrange@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Mahesh Jagannath Salgaonkar <mahesh@linux.vnet.ibm.com>, Ananth <ananth@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

ACK, works well!
A suggestion though..

On 10/20/2010 07:39 PM, Daniel P. Berrange wrote:
>
> eg, instead of
>
>    probe process("qemu").mark("qemu_malloc") {
>      printf("Malloc %d %p\n", $arg1, $arg2);
>    }
>
> The addition of qemu.stp to /usr/share/systemtap/tapset/
> lets users write
>
>    probe qemu.qemu_malloc {
>      printf("Malloc %d %p\n", size, ptr);
>    }
>...
>
>
> diff --git a/tracetool b/tracetool
> index 7010858..047f16b 100755
> --- a/tracetool
> +++ b/tracetool
> +linetos_dtrace()
> +{
> +    local name args arglist state
> +
> +    # Define prototype for probe arguments
> +    cat<<EOF
> +probe qemu.$name = process("qemu").mark("$name")
> +{

The 'process' probes only work by looking for the binary in $PATH, 
unless the full path is specified. When compiling qemu in non-standard 
locations ( ie with --prefix), such probes would not point to the 
correct binary. It could be nice if tracetool could pass the full build 
path for defining the probe point. Eg,

probe qemu.qemu_malloc = 
process("/Path/to/build/dir/bin/qemu").mark("qemu_malloc") { .. }

-- 
Prerna Saxena

Linux Technology Centre,
IBM Systems and Technology Lab,
Bangalore, India