From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45762 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PBBod-0002bo-9O
	for qemu-devel@nongnu.org; Wed, 27 Oct 2010 15:37:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PBBob-0001tV-QD
	for qemu-devel@nongnu.org; Wed, 27 Oct 2010 15:37:43 -0400
Received: from mail-iw0-f173.google.com ([209.85.214.173]:59241)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PBBob-0001t6-NF
	for qemu-devel@nongnu.org; Wed, 27 Oct 2010 15:37:41 -0400
Received: by iwn36 with SMTP id 36so1330664iwn.4
	for <qemu-devel@nongnu.org>; Wed, 27 Oct 2010 12:37:40 -0700 (PDT)
Message-ID: <4CC87F84.3050609@codemonkey.ws>
Date: Wed, 27 Oct 2010 14:37:40 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC 0/2]: QMP: Human Monitor passthrough
References: <1288037204-27768-1-git-send-email-lcapitulino@redhat.com>
In-Reply-To: <1288037204-27768-1-git-send-email-lcapitulino@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, armbru@redhat.com

On 10/25/2010 03:06 PM, Luiz Capitulino wrote:
> This is my first try on implementing HMP passthrough via QMP. I've tried
> to follow Anthony's advice on creating a buffered char device.
>
> If this approach is good (and the implementation is not faulty), I believe
> this is very near a mergeble state (although I haven't tested much yet).
>    

Looks good to me.

Regards,

Anthony Liguori

> Example:
>
> ->  { "execute": "hmp_passthrough", "arguments": { "command-line": "print /i 10+25" } }
> <- { "return": "35\r\n" }
>
> Thanks.
>
>
>