From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=52393 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PBOlw-0004KU-Cs for qemu-devel@nongnu.org; Thu, 28 Oct 2010 05:27:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PBOlu-0004Qd-Gh for qemu-devel@nongnu.org; Thu, 28 Oct 2010 05:27:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5847) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PBOlu-0004QZ-AF for qemu-devel@nongnu.org; Thu, 28 Oct 2010 05:27:46 -0400 Message-ID: <4CC94203.1080207@redhat.com> Date: Thu, 28 Oct 2010 11:27:31 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH] Implement a virtio GPU transport References: <4CAC9CD1.2050601@collabora.co.uk> <4CB1D79A.6070805@redhat.com> <4CBD739A.2010500@collabora.co.uk> <4CBD7560.6080207@redhat.com> <4CC8226F.5080807@collabora.co.uk> In-Reply-To: <4CC8226F.5080807@collabora.co.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ian Molton Cc: virtualization@lists.osdl.org, linux-kernel@vger.kernel.org, QEMU Developers On 10/27/2010 03:00 PM, Ian Molton wrote: > On 19/10/10 11:39, Avi Kivity wrote: >> On 10/19/2010 12:31 PM, Ian Molton wrote: > >>>> 2. should start with a patch to the virtio-pci spec to document what >>>> you're doing >>> >>> Where can I find that spec? >> >> http://ozlabs.org/~rusty/virtio-spec/ > > Ok, but I'm not patching that until theres been some review. Well, I like to review an implementation against a spec. > > There are links to the associated qemu and guest OS changes in my > original email. > >>> It doesnt, at present... It could be changed fairly easily ithout >>> breaking anything if that happens though. >> >> The hypervisor and the guest can be changed independently. The driver >> should be coded so that it doesn't depend on hypervisor implementation >> details. > > Fixed - updated patch tested and attached. > + > + /* Transfer data */ > + if (virtqueue_add_buf(vq, sg_list, o_page, i_page, gldata)>= 0) { > + virtqueue_kick(vq); > + /* Chill out until it's done with the buffer. */ > + wait_for_completion(&gldata->done); > + } > + Better, but still unsatisfying. If the server is busy, the caller would block. I guess it's expected since it's called from ->fsync(). I'm not sure whether that's the best interface, perhaps aio_writev is better. -- error compiling committee.c: too many arguments to function