From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37225 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PBPNU-0000hX-7N for qemu-devel@nongnu.org; Thu, 28 Oct 2010 06:06:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PBPNO-00039C-74 for qemu-devel@nongnu.org; Thu, 28 Oct 2010 06:06:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43129) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PBPNN-000398-Vh for qemu-devel@nongnu.org; Thu, 28 Oct 2010 06:06:30 -0400 Message-ID: <4CC94B1E.10502@redhat.com> Date: Thu, 28 Oct 2010 12:06:22 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/6] The windows 7 audio support patch series. References: <1288195475-3807-1-git-send-email-kraxel@redhat.com> <4CC93894.3030008@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: qemu-devel@nongnu.org Hi, > At the very least their code does work here (on a PPC with DOS and > mpxplay) and yours doesn't. I'd have to check things on my x86_64 box > to ensure it's not a endianness issue of some sort, It most likely *is* endianness, the mmio_read/write handlers don't swap bytes on bigendian hosts. That is the only endian issue I'm aware of though. Guest memory access goes through {stl,ldl}_phys() + friends and thus should be fine as-is. /me goes try dos+mpxplay ... cheers, Gerd