From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37754 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PBQbX-00031w-DX for qemu-devel@nongnu.org; Thu, 28 Oct 2010 07:25:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PBQGG-0006D6-8t for qemu-devel@nongnu.org; Thu, 28 Oct 2010 07:03:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56953) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PBQGF-0006Cp-Vt for qemu-devel@nongnu.org; Thu, 28 Oct 2010 07:03:12 -0400 Message-ID: <4CC95862.8090908@redhat.com> Date: Thu, 28 Oct 2010 13:02:58 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH v3 5/5] qed: Consistency check support References: <1287759383-14114-1-git-send-email-stefanha@linux.vnet.ibm.com> <1287759383-14114-6-git-send-email-stefanha@linux.vnet.ibm.com> <4CC84AA4.2030701@redhat.com> <4CC9527C.1000304@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Anthony Liguori , Stefan Hajnoczi , Juan Quintela , qemu-devel@nongnu.org, Christoph Hellwig On 10/28/2010 12:51 PM, Stefan Hajnoczi wrote: > > > > Opening the file read-only first and reopening it read-write when the > > migration has completed would be much better. No image format driver > > would have to be changed for that. > > I agree. I'm not sure whether NFS guarantees we see the latest data > when reopening read-write (cached pages will be left on the > destination host from the initial read-only access). > AFAICT the re-open has to re-validate the metadata. If ctime has changed since the previous stat, the client has to drop local caches. -- error compiling committee.c: too many arguments to function