From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=54034 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PBUJr-0002vj-R4
	for qemu-devel@nongnu.org; Thu, 28 Oct 2010 11:23:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hpa@linux.intel.com>) id 1PBUJo-0003kO-QN
	for qemu-devel@nongnu.org; Thu, 28 Oct 2010 11:23:11 -0400
Received: from mga11.intel.com ([192.55.52.93]:29787)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hpa@linux.intel.com>) id 1PBUJo-0003jq-Lx
	for qemu-devel@nongnu.org; Thu, 28 Oct 2010 11:23:08 -0400
Message-ID: <4CC9955A.9090809@linux.intel.com>
Date: Thu, 28 Oct 2010 08:23:06 -0700
From: "H. Peter Anvin" <hpa@linux.intel.com>
MIME-Version: 1.0
References: <1288195475-3807-1-git-send-email-kraxel@redhat.com>
	<1288195475-3807-6-git-send-email-kraxel@redhat.com>
	<4CC85DA5.9090704@linux.intel.com> <4CC92DEC.7060708@redhat.com>
In-Reply-To: <4CC92DEC.7060708@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 5/6] Add support for a USB audio device
	model
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On 10/28/2010 1:01 AM, Gerd Hoffmann wrote:
> On 10/27/10 19:13, H. Peter Anvin wrote:
>> On 10/27/2010 9:04 AM, Gerd Hoffmann wrote:
>
>>> This brings a usb audio device to qemu. Output only, fixed at
>>> 16bit stereo @ 480000 Hz. Based on a patch from
>>> H. Peter Anvin<hpa@linux.intel.com>
>
>> Please don't apply this. This patch is outdated and has several glaring
>> bugs. I can send a better patch later (I'm in an all-day meeting with
>> insanely bad networking.)
>
> Oh, I thought you've abandoned the project ...
>
> Note that I've update the patch too and fixed at least some of those
> bugs. Nevertheless I'll be happy to see your latest bits and try to
> merge the best of both versions.
>

I have a git tree on kernel.org with the latest version.  However, the 
rate-matching code needs to be ripped out since it just plain doesn't 
work, and tends to produce worse results than no rate matching:

http://git.kernel.org/?p=virt/qemu/hpa/qemu-usb-audio-wip.git;a=shortlog;h=refs/heads/usb-audio

	-hpa