From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=46776 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PCwnF-0003pB-TH for qemu-devel@nongnu.org; Mon, 01 Nov 2010 11:59:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PCwn1-0003lm-50 for qemu-devel@nongnu.org; Mon, 01 Nov 2010 11:59:22 -0400 Received: from mail-iw0-f173.google.com ([209.85.214.173]:43523) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PCwn1-0003lW-1A for qemu-devel@nongnu.org; Mon, 01 Nov 2010 11:59:19 -0400 Received: by iwn36 with SMTP id 36so7501630iwn.4 for ; Mon, 01 Nov 2010 08:59:18 -0700 (PDT) Message-ID: <4CCEE3D4.80800@codemonkey.ws> Date: Mon, 01 Nov 2010 10:59:16 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 08/40] xenner: kernel: 64-bit files References: <1288623713-28062-1-git-send-email-agraf@suse.de> <1288623713-28062-9-git-send-email-agraf@suse.de> <4CCEE053.9020906@codemonkey.ws> <9D1D39AB-C25C-40EB-AFE3-41122A681D4F@suse.de> In-Reply-To: <9D1D39AB-C25C-40EB-AFE3-41122A681D4F@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel Developers , Gerd Hoffmann On 11/01/2010 10:47 AM, Alexander Graf wrote: > On 01.11.2010, at 11:44, Anthony Liguori wrote: > > >> On 11/01/2010 10:01 AM, Alexander Graf wrote: >> >>> This patch adds various header files required for the xenner kernel on 64 bit >>> systems. >>> >>> Signed-off-by: Alexander Graf >>> >>> >> I think it might make more sense to put this on a separate git.qemu.org repository and then use a submodule in roms/. >> > The main reason why I wanted to have it fully in the qemu tree is so that we can guarantee the qemu<->xenner interface is 100% private. I'm not sure how much it'll be in a flux, but I don't want to go through the hassle of defining stable ABIs where we don't have to :) > Yeah, I'm not suggesting it be a separate project. But we've been keeping firmware out of tree for the most part and using submodules. I like this model (even though git submodules don't always work the way you expect them to..). I'm not passionate either way. If you feel strongly about it being in the main source tree, I don't have a problem with it. But stick it in roms/ instead of pc-bios. Regards, Anthony Liguori > Alex > >