From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45092 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PCzJf-0005Jt-V4
	for qemu-devel@nongnu.org; Mon, 01 Nov 2010 14:41:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PCzJe-000514-Mc
	for qemu-devel@nongnu.org; Mon, 01 Nov 2010 14:41:11 -0400
Received: from mail-yx0-f173.google.com ([209.85.213.173]:53834)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PCzJe-00050y-Ia
	for qemu-devel@nongnu.org; Mon, 01 Nov 2010 14:41:10 -0400
Received: by yxd5 with SMTP id 5so3783848yxd.4
	for <qemu-devel@nongnu.org>; Mon, 01 Nov 2010 11:41:10 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4CCF09C1.7050006@redhat.com>
Date: Mon, 01 Nov 2010 19:41:05 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1288623713-28062-1-git-send-email-agraf@suse.de>
	<1288623713-28062-3-git-send-email-agraf@suse.de>
In-Reply-To: <1288623713-28062-3-git-send-email-agraf@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 02/40] elf: Add notes implementation
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel Developers <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>

On 11/01/2010 04:01 PM, Alexander Graf wrote:
> diff --git a/hw/loader.c b/hw/loader.c
> index 50b43a0..cb430e0 100644
> --- a/hw/loader.c
> +++ b/hw/loader.c
> @@ -229,6 +229,11 @@ int load_aout(const char *filename, target_phys_addr_t addr, int max_sz,
>
>   /* ELF loader */
>
> +static void elf_default_note(void *opaque, uint8_t *name, uint32_t name_len,
> +                             uint8_t *desc, uint32_t desc_len, uint32_t type)
> +{
> +}
> +
>   static uint64_t elf_default_translate(void *opaque, uint64_t addr)
>   {
>       return addr;
> @@ -237,6 +242,8 @@ static uint64_t elf_default_translate(void *opaque, uint64_t addr)
>   ElfHandlers elf_default_handlers = {
>       .translate_fn = elf_default_translate,
>       .translate_opaque = NULL,
> +    .note_fn = elf_default_note,
> +    .note_opaque = NULL,

Don't you have to add the definition to every user of translate_fn?

Maybe it's better to guard calls through the pointers with an if.

Paolo