From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42225 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PCzOV-00015a-CT
	for qemu-devel@nongnu.org; Mon, 01 Nov 2010 14:46:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PCzOU-0005sW-6a
	for qemu-devel@nongnu.org; Mon, 01 Nov 2010 14:46:11 -0400
Received: from mail-pz0-f45.google.com ([209.85.210.45]:49449)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PCzOU-0005sM-0i
	for qemu-devel@nongnu.org; Mon, 01 Nov 2010 14:46:10 -0400
Received: by pzk4 with SMTP id 4so666155pzk.4
	for <qemu-devel@nongnu.org>; Mon, 01 Nov 2010 11:46:09 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4CCF0AED.2090002@redhat.com>
Date: Mon, 01 Nov 2010 19:46:05 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1288623713-28062-1-git-send-email-agraf@suse.de>
	<1288623713-28062-15-git-send-email-agraf@suse.de>
In-Reply-To: <1288623713-28062-15-git-send-email-agraf@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 14/40] xenner: kernel: Instruction emulator
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel Developers <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>

On 11/01/2010 04:01 PM, Alexander Graf wrote:
> +    /* I/O instruction */
> +    if (in == 2) {
> +        regs->rax |= 0xffffffff;
> +    } else if (in == 1) {
> +        regs->rax |= (0xffff<<  shift);
> +    }

I don't understand this, and also why it's here rather than near case 
0xe4/0xe5/0xec/0xed.

Paolo