From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37420 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PD1rA-0007FQ-KD
	for qemu-devel@nongnu.org; Mon, 01 Nov 2010 17:23:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PD1r8-0004lq-Qe
	for qemu-devel@nongnu.org; Mon, 01 Nov 2010 17:23:56 -0400
Received: from mail-fx0-f45.google.com ([209.85.161.45]:65005)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PD1r8-0004lS-Hm
	for qemu-devel@nongnu.org; Mon, 01 Nov 2010 17:23:54 -0400
Received: by fxm4 with SMTP id 4so5568410fxm.4
	for <qemu-devel@nongnu.org>; Mon, 01 Nov 2010 14:23:50 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4CCF2FE2.6080003@redhat.com>
Date: Mon, 01 Nov 2010 22:23:46 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1288623713-28062-1-git-send-email-agraf@suse.de>	<1288623713-28062-3-git-send-email-agraf@suse.de>	<4CCF09C1.7050006@redhat.com>	<7017E7AA-5488-45CD-AD25-416891E2A311@suse.de>	<4CCF187A.1060105@redhat.com>
	<52FE1E42-52DA-480C-A4C8-4B0A84C13D3A@suse.de>
In-Reply-To: <52FE1E42-52DA-480C-A4C8-4B0A84C13D3A@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 02/40] elf: Add notes implementation
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel Developers <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>

On 11/01/2010 08:48 PM, Alexander Graf wrote:
> @@ -106,8 +106,10 @@ static int64_t load_kernel (CPUState *env)
>      ram_addr_t initrd_offset;
>      uint32_t *prom_buf;
>      long prom_size;
> +    ElfHandlers handlers = elf_default_handlers;
>
> -    if (load_elf(loaderparams.kernel_filename, cpu_mips_kseg0_to_phys, NULL,
> +    handlers.translate_fn = cpu_mips_kseg0_to_phys;
> +    if (load_elf(loaderparams.kernel_filename,&handlers,
>                   (uint64_t *)&kernel_entry, (uint64_t *)&kernel_low,
>                   (uint64_t *)&kernel_high, 0, ELF_MACHINE, 1)<  0) {
>          fprintf(stderr, "qemu: could not load kernel '%s'\n",
>
>
> Unless my C foo is really bad, this means that handlers is
> initialized  with the contents of elf_default_handlers :). And
> that's how every caller works.

Sorry, my mistake.

Paolo