From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42367 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PFmr9-0002Ze-V7
	for qemu-devel@nongnu.org; Tue, 09 Nov 2010 06:59:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PFmiQ-0000xR-R3
	for qemu-devel@nongnu.org; Tue, 09 Nov 2010 06:51:53 -0500
Received: from mx1.redhat.com ([209.132.183.28]:56505)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PFmiQ-0000xK-GC
	for qemu-devel@nongnu.org; Tue, 09 Nov 2010 06:50:18 -0500
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oA9BoHIQ025107
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 9 Nov 2010 06:50:17 -0500
Message-ID: <4CD93573.7040009@redhat.com>
Date: Tue, 09 Nov 2010 12:50:11 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1288623114-14439-1-git-send-email-kraxel@redhat.com>
	<20101108174752.GC8498@redhat.com> <4CD91661.6030102@redhat.com>
	<20101109113453.GA22705@redhat.com>
In-Reply-To: <20101109113453.GA22705@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] add VMSTATE_BOOL
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

   Hi,

>>>> +static int get_bool(QEMUFile *f, void *pv, size_t size)
>>>> +{
>>>> +    bool *v = pv;
>>>> +    *v = qemu_get_byte(f);
>>>> +    return 0;

> I think we should verify that value is 0 or 1 and fail
> migration otherwise, to make it more robust.

I still think such a check doesn't belong into the migration code as 
such a bug would exist without migration too.  And if anything we should 
check on save not on load, otherwise qemu can write out savevm images 
which it will refuse to load.  I wouldn't call this "robust".

cheers,
   Gerd