From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=35279 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PGEmC-0001Ee-SN
	for qemu-devel@nongnu.org; Wed, 10 Nov 2010 12:48:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PGEm8-000430-O6
	for qemu-devel@nongnu.org; Wed, 10 Nov 2010 12:48:01 -0500
Received: from mail-qy0-f173.google.com ([209.85.216.173]:48563)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PGEm8-00042s-Gj
	for qemu-devel@nongnu.org; Wed, 10 Nov 2010 12:48:00 -0500
Received: by qyl33 with SMTP id 33so3455818qyl.4
	for <qemu-devel@nongnu.org>; Wed, 10 Nov 2010 09:48:00 -0800 (PST)
Message-ID: <4CDADACC.4070405@codemonkey.ws>
Date: Wed, 10 Nov 2010 11:47:56 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH] Implement a virtio GPU transport
References: <1097264455.965471288612409433.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>	<4CCEC090.3050009@codemonkey.ws>	<4CD1A406.3090909@collabora.co.uk>
	<4CD1A73B.2010406@codemonkey.ws> <4CD44759.5020500@collabora.co.uk>
	<4CDAD4D4.3070009@collabora.co.uk>
In-Reply-To: <4CDAD4D4.3070009@collabora.co.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ian Molton <ian.molton@collabora.co.uk>
Cc: linux-kernel@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>, QEMU Developers <qemu-devel@nongnu.org>, virtualization@lists.linux-foundation.org, virtualization@lists.osdl.org, Alon Levy <alevy@redhat.com>, Avi Kivity <avi@redhat.com>

On 11/10/2010 11:22 AM, Ian Molton wrote:
> Ping ?

I think the best way forward is to post patches.

To summarize what I was trying to express in the thread, I think this is 
not the right long term architecture but am not opposed to it as a short 
term solution.  I think having a new virtio device is a bad design 
choice but am not totally opposed to it.

My advice is that using virtio-serial + an external tool is probably the 
least amount of work to get something working and usable with QEMU.  If 
you want to go for the path of integration, you're going to have to fix 
all of the coding style issues and make the code fit into QEMU.  
Dropping a bunch of junk into target-i386/ is not making the code fit 
into QEMU.

If you post just what you have now in patch form, I can try to provide 
more concrete advice ignoring the coding style problems.

Regards,

Anthony Liguori