qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	ohmura.kei@lab.ntt.co.jp, qemu-devel@nongnu.org,
	Liran Schour <LIRANS@il.ibm.com>
Subject: [Qemu-devel] Re: [patch 0/3] block migration fixes
Date: Thu, 11 Nov 2010 18:06:02 +0900	[thread overview]
Message-ID: <4CDBB1FA.1010402@lab.ntt.co.jp> (raw)
In-Reply-To: <20101109130843.GA24340@amt.cnet>

Marcelo Tosatti wrote:
> On Tue, Nov 09, 2010 at 03:02:12PM +0900, Yoshiaki Tamura wrote:
>> Marcelo Tosatti wrote:
>>> Following patchset fixes block migration corruption issues.
>>
>> Hi Marcelo,
>>
>> Thanks for looking into this issue.  Although we tried your patches, we're still
>> seeing the corruption.  If we execute block migration while copying a file
>> locally, md5sum of the copied file doesn't match with the original.  Sometimes,
>> the filesystem returns an I/O error.
>>
>> Could you let us know how you tested and debugged?  Did you use blkverify?
>
> Yoshiaki,
>
> I first reproduced corruption by copying a large file during "migrate
> -i", with shared base on qcow2 filesystem, as in your original report.
>
> To debug the problem, file with different byte pattern at every 1MB
> (size of dirty chunk) was created and copied directly to an IDE disk in
> the guest. Raw format used for the disk image.
>
> With this patchset, i'm not able to reproduce the original issue
> anymore.
>
> Can you please provide more details on how to reproduce?

Marcelo,

We double checked and the patchset does seem to fix the problem.  The was a 
mistake in our test procedure.  Sorry for the confusion.

Thanks,

Yoshi

  reply	other threads:[~2010-11-11  9:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-08 19:02 [Qemu-devel] [patch 0/3] block migration fixes Marcelo Tosatti
2010-11-08 19:02 ` [Qemu-devel] [patch 1/3] block: fix shift in dirty bitmap calculation Marcelo Tosatti
2010-11-09 12:02   ` [Qemu-devel] " Kevin Wolf
2010-11-08 19:02 ` [Qemu-devel] [patch 2/3] block: set sector dirty on AIO write completion Marcelo Tosatti
2010-11-09 12:02   ` [Qemu-devel] " Kevin Wolf
2010-11-08 19:02 ` [Qemu-devel] [patch 3/3] block migration: do not submit multiple AIOs for same sector Marcelo Tosatti
2010-11-09 12:42   ` [Qemu-devel] " Kevin Wolf
2010-11-09 13:49     ` Marcelo Tosatti
2010-11-09  6:02 ` [Qemu-devel] Re: [patch 0/3] block migration fixes Yoshiaki Tamura
2010-11-09 13:08   ` Marcelo Tosatti
2010-11-11  9:06     ` Yoshiaki Tamura [this message]
2010-11-12 15:56       ` Marcelo Tosatti
2010-11-21 15:22 ` [Qemu-devel] " Anthony Liguori
2010-11-22  9:43   ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CDBB1FA.1010402@lab.ntt.co.jp \
    --to=tamura.yoshiaki@lab.ntt.co.jp \
    --cc=LIRANS@il.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=ohmura.kei@lab.ntt.co.jp \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).