From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=45326 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PGU3i-0007pk-JX for qemu-devel@nongnu.org; Thu, 11 Nov 2010 05:07:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PGU3h-0008Ta-HF for qemu-devel@nongnu.org; Thu, 11 Nov 2010 05:07:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34586) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PGU3h-0008TC-AI for qemu-devel@nongnu.org; Thu, 11 Nov 2010 05:07:09 -0500 Message-ID: <4CDBC045.3070902@redhat.com> Date: Thu, 11 Nov 2010 11:07:01 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1289409261-5418-1-git-send-email-gleb@redhat.com> <1289409261-5418-9-git-send-email-gleb@redhat.com> <20101110173412.GE3891@redhat.com> In-Reply-To: <20101110173412.GE3891@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: kvm@vger.kernel.org, Gleb Natapov , armbru@redhat.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, alex.williamson@redhat.com On 11/10/10 18:34, Michael S. Tsirkin wrote: > On Wed, Nov 10, 2010 at 07:14:15PM +0200, Gleb Natapov wrote: >> >> Signed-off-by: Gleb Natapov > > Good stuff. We should also consider using this for > CLI and monitor. Some comments below. Oh, we already have a table to map pci classes to descriptions for 'info pci'. I'd strongly suggest to just add the fw names to that table instead of creating a second one ... cheers, Gerd