From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56653 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PGqRH-0008Pk-9U
	for qemu-devel@nongnu.org; Fri, 12 Nov 2010 05:01:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PGqRG-00039H-AG
	for qemu-devel@nongnu.org; Fri, 12 Nov 2010 05:00:59 -0500
Received: from mail-fx0-f45.google.com ([209.85.161.45]:60994)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PGqRG-000397-48
	for qemu-devel@nongnu.org; Fri, 12 Nov 2010 05:00:58 -0500
Received: by fxm18 with SMTP id 18so2184662fxm.4
	for <qemu-devel@nongnu.org>; Fri, 12 Nov 2010 02:00:57 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4CDD1057.7060103@redhat.com>
Date: Fri, 12 Nov 2010 11:00:55 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <AANLkTinVH89VQzNPB6PRuxnvzkYCtTG_-P1HBkQuTohK@mail.gmail.com>	<4C5EACF8.1010101@redhat.com>	<AANLkTikZY9cf9TBdH79+Kw9HrvUC6WM6JtyACqatorQD@mail.gmail.com>	<AANLkTin3XAZAFcARy9V3aETD9DVoMpoP-QW6ROVJrq2-@mail.gmail.com>
	<AANLkTinQYEQ1U4s6MbJw4rFL-XB-Wd2oMq_Vd3AoQ+O4@mail.gmail.com>
In-Reply-To: <AANLkTinQYEQ1U4s6MbJw4rFL-XB-Wd2oMq_Vd3AoQ+O4@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [patch] fix scsi-generic
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: adq <adq@lidskialf.net>
Cc: qemu-devel@nongnu.org

On 08/09/2010 01:51 AM, adq wrote:
> Figured out what the problem is - READ DVD STRUCTURE has its xfer
> length in an unexpected place, so hw/scsi-bus.c retrieves completely
> the wrong value for the transfer length. Attached nasty hacky (!)
> patch fixes it as a proof of concept, will see what I can do to clean
> it up later. I'd probably want it to warn if it sees SCSI commands it
> doesn't know how to explicitly handle to aid debugging this sort of
> thing in future.

Hi Andrew, are you going to submit a similar patch in definitive form?

Paolo