From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=55213 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PGspX-00078W-KL for qemu-devel@nongnu.org; Fri, 12 Nov 2010 07:34:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PGspV-0001u4-LH for qemu-devel@nongnu.org; Fri, 12 Nov 2010 07:34:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40824) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PGspV-0001tn-Dn for qemu-devel@nongnu.org; Fri, 12 Nov 2010 07:34:09 -0500 Message-ID: <4CDD3435.7040605@redhat.com> Date: Fri, 12 Nov 2010 13:33:57 +0100 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] virtio-9p: fix build on !CONFIG_UTIMENSAT v2 References: <20101104170303.GE15211@sequoia.sous-sol.org> <4CD3A513.2010102@jp.fujitsu.com> <201011081214.28202.mohan@in.ibm.com> In-Reply-To: <201011081214.28202.mohan@in.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "M. Mohan Kumar" Cc: Chris Wright , Hidetoshi Seto , "kvm@vger.kernel.org" , "Hao, Xudong" , qemu-devel@nongnu.org, Blue Swirl , Avi Kivity On 11/08/10 07:44, M. Mohan Kumar wrote: >> This patch introduce a fallback mechanism for old systems that do not >> support utimensat. This will fix build failure with following warnings: >> >> hw/virtio-9p-local.c: In function 'local_utimensat': >> hw/virtio-9p-local.c:479: warning: implicit declaration of function >> 'utimensat' hw/virtio-9p-local.c:479: warning: nested extern declaration >> of 'utimensat' >> >> and >> >> hw/virtio-9p.c: In function 'v9fs_setattr_post_chmod': >> hw/virtio-9p.c:1410: error: 'UTIME_NOW' undeclared (first use in this >> function) hw/virtio-9p.c:1410: error: (Each undeclared identifier is >> reported only once hw/virtio-9p.c:1410: error: for each function it >> appears in.) >> hw/virtio-9p.c:1413: error: 'UTIME_OMIT' undeclared (first use in this >> function) hw/virtio-9p.c: In function 'v9fs_wstat_post_chmod': >> hw/virtio-9p.c:2905: error: 'UTIME_OMIT' undeclared (first use in this >> function) >> >> Signed-off-by: Hidetoshi Seto >> --- >> hw/virtio-9p-local.c | 32 ++++++++++++++++++++++++++++++-- >> hw/virtio-9p.h | 10 ++++++++++ >> 2 files changed, 40 insertions(+), 2 deletions(-) >> >> diff --git a/hw/virtio-9p-local.c b/hw/virtio-9p-local.c >> index 0d52020..7811d2c 100644 >> --- a/hw/virtio-9p-local.c >> +++ b/hw/virtio-9p-local.c >> @@ -479,10 +479,38 @@ static int local_chown(FsContext *fs_ctx, const char >> *path, FsCred *credp) return -1; >> } >> >> +/* TODO: relocate this to proper file, and make it more generic */ >> +static int qemu_utimensat(int dirfd, const char *path, >> + const struct timespec *times, int flags) >> +{ > > IMHO, this code can be moved to cutils.c It's not a C utility function, so it really belongs in oslib-posix.c, but otherwise I agree. This is emulation of a C library function, it shouldn't be in the 9p code. Cheers, Jes